[jira] [Created] (OFBIZ-4768) Improvement for flatgray theme

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253842#comment-13253842 ]

Pierre Smits commented on OFBIZ-4768:
-------------------------------------

Wai,

Unfortunately I see no added value in implementing these changes to the trunk version of the Flatgrey theme. I agree with Jacques that it is something for Extra as there is a marketspace for every niche product. And out there, there definitely will be persons who appreciate your vision.

My advice to you: make it a complete theme (not just the modifications), document well and post the total package on Extra.

Regards,

Pierre
               

> Improvement for flatgrey theme
> ------------------------------
>
>                 Key: OFBIZ-4768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>            Reporter: Wai
>            Priority: Trivial
>         Attachments: after-sample-catalogmgr1.png, after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, after-sample-catalogmgr2.png, after-sample-partymgr.png, after-sample-partymgr.png, after-sample-webtools.png, after-sample-webtools.png, before-sample-catalogmgr1.png, before-sample-catalogmgr2.png, before-sample-partymgr.png, before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style2.patch
>
>
> Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wai updated OFBIZ-4768:
-----------------------

    Attachment: ofbiz-style2.patch
                ofbiz-style1.patch

Hello Committer(s),

As of the recent previous comments.  I'm left with an assumption that either the improvement offers absolutely no value to the project or that the risk of integrating the change compared to the benefit obtained would be too great.

If my understanding that the change offers no value because the styling is disagreeable. I'll abide by the committer's decision and I'll close this issue.

If the reason for the decision is based on previous patches containing too many changes such that it rendered using 'diff' incomprehensible.  It was a shortsightedness on my part due to formatting the files.  I have thus included the 2 patches without the file formatting and I hope that the committer(s) can see the actual changes to the original file and would reconsider.

Either way, I'll abide by your final decision.

Thanks for your consideration.
Wai
               

> Improvement for flatgrey theme
> ------------------------------
>
>                 Key: OFBIZ-4768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>            Reporter: Wai
>            Priority: Trivial
>         Attachments: after-sample-catalogmgr1.png, after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, after-sample-catalogmgr2.png, after-sample-partymgr.png, after-sample-partymgr.png, after-sample-webtools.png, after-sample-webtools.png, before-sample-catalogmgr1.png, before-sample-catalogmgr2.png, before-sample-partymgr.png, before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style1.patch, ofbiz-style2.patch, ofbiz-style2.patch
>
>
> Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254532#comment-13254532 ]

Pierre Smits commented on OFBIZ-4768:
-------------------------------------

Wai,

Worry not. Acceptance of changes in themes (unless it are bug fixes) is highly determined by the likability or wow factor and personal taste. That your changes didn't make it into the trunk has to do with that. Not with the amount of iterations it went through to get it right. We all have been through that when we started with submitting patches. It is the latest patch provided that is important, right...

Just communicate your patch on the user ML and see if people adopt it.

Regards,

Pierre
               

> Improvement for flatgrey theme
> ------------------------------
>
>                 Key: OFBIZ-4768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>            Reporter: Wai
>            Priority: Trivial
>         Attachments: after-sample-catalogmgr1.png, after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, after-sample-catalogmgr2.png, after-sample-partymgr.png, after-sample-partymgr.png, after-sample-webtools.png, after-sample-webtools.png, before-sample-catalogmgr1.png, before-sample-catalogmgr2.png, before-sample-partymgr.png, before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style1.patch, ofbiz-style2.patch, ofbiz-style2.patch
>
>
> Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wai closed OFBIZ-4768.
----------------------

    Resolution: Won't Fix
   

> Improvement for flatgrey theme
> ------------------------------
>
>                 Key: OFBIZ-4768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>            Reporter: Wai
>            Priority: Trivial
>         Attachments: after-sample-catalogmgr1.png, after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, after-sample-catalogmgr2.png, after-sample-partymgr.png, after-sample-partymgr.png, after-sample-webtools.png, after-sample-webtools.png, before-sample-catalogmgr1.png, before-sample-catalogmgr2.png, before-sample-partymgr.png, before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style1.patch, ofbiz-style2.patch, ofbiz-style2.patch
>
>
> Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504874#comment-13504874 ]

Olivier Heintz commented on OFBIZ-4768:
---------------------------------------

Wai,

I have used this Jira and its patch to create two addon on ofbizextra-addons-dev
- flatgrey-update2variation : apply your patch to the flatgrey theme
- theme-flatgreyvariation : add a new theme "flatgreyvariation" which is the flatgrey theme with your patch applied.

regards,
Olivier

               

> Improvement for flatgrey theme
> ------------------------------
>
>                 Key: OFBIZ-4768
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4768
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>            Reporter: Wai
>            Priority: Trivial
>         Attachments: after-sample-catalogmgr1.png, after-sample-catalogmgr1.png, after-sample-catalogmgr2.png, after-sample-catalogmgr2.png, after-sample-partymgr.png, after-sample-partymgr.png, after-sample-webtools.png, after-sample-webtools.png, before-sample-catalogmgr1.png, before-sample-catalogmgr2.png, before-sample-partymgr.png, before-sample-webtools.png, flatgray-images.tar.gz, ofbiz-4768.patch, ofbiz-4768.patch, ofbiz-style1.patch, ofbiz-style1.patch, ofbiz-style2.patch, ofbiz-style2.patch
>
>
> Improvement to flatgrey theme.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira