[jira] [Created] (OFBIZ-4940) TaxAuthorityServices try to filter by date without getting date fields

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4940) TaxAuthorityServices try to filter by date without getting date fields

Nicolas Malin (Jira)
Alexander Reelsen created OFBIZ-4940:
----------------------------------------

             Summary: TaxAuthorityServices try to filter by date without getting date fields
                 Key: OFBIZ-4940
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4940
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Alexander Reelsen


The TaxAuthorityServices try to get product category members and filter by date. However they do not get the fromDate/thruDate fields and therefore EntityUtil.filterByDate() fails silently. This can lead to accumulated tax when two different tax rates were active on two totally different time ranges.

Fix is changing line 329 from

List<GenericValue> pcmList = delegator.findList("ProductCategoryMember", productIdCond, UtilMisc.toSet("productCategoryId"), null, null, true);

to

List<GenericValue> pcmList = delegator.findList("ProductCategoryMember", productIdCond, UtilMisc.toSet("productCategoryId", "fromDate", "thruDate"), null, null, true);



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira