OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-511) Patch to remove unnecessary casts

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-511) Patch to remove unnecessary casts

Patch to remove unnecessary casts
---------------------------------

Key: OFBIZ-511
URL: http://issues.apache.org/jira/browse/OFBIZ-511
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: Stefan Huehner
Priority: Trivial

Hi,

this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

[ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Stefan Huehner updated OFBIZ-511:
---------------------------------

Attachment: ofbiz_cast1.diff

> Patch to remove unnecessary casts
> ---------------------------------
>
> Key: OFBIZ-511
> URL: http://issues.apache.org/jira/browse/OFBIZ-511
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Trivial
> Attachments: ofbiz_cast1.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Stefan Huehner updated OFBIZ-511:
---------------------------------

Attachment: ofbiz_cast1a.diff

Please use this patch instead, which reverts one change in the previous diff (framework/base/src/base/org/ofbiz/base/util/KeyStoreUtil.java).
The former patch triggers a compile error when using the ant build script which i've missed as it didn't show up while building inside the ide.

> Patch to remove unnecessary casts
> ---------------------------------
>
> Key: OFBIZ-511
> URL: http://issues.apache.org/jira/browse/OFBIZ-511
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Trivial
> Attachments: ofbiz_cast1.diff, ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-511) Patch to remove unnecessary casts

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato updated OFBIZ-511:
------------------------------------

Attachment: (was: ofbiz_cast1.diff)

> Patch to remove unnecessary casts
> ---------------------------------
>
> Key: OFBIZ-511
> URL: http://issues.apache.org/jira/browse/OFBIZ-511
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Trivial
> Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-511) Patch to remove unnecessary casts

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato reassigned OFBIZ-511:
---------------------------------------

Assignee: Jacopo Cappellato

> Patch to remove unnecessary casts
> ---------------------------------
>
> Key: OFBIZ-511
> URL: http://issues.apache.org/jira/browse/OFBIZ-511
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacopo Cappellato
> Priority: Trivial
> Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-511) Patch to remove unnecessary casts

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-511?page=all ]

Jacopo Cappellato closed OFBIZ-511.
-----------------------------------

Resolution: Fixed

Thanks Stefan,

your patch is in svn with rev. 481546

> Patch to remove unnecessary casts
> ---------------------------------
>
> Key: OFBIZ-511
> URL: http://issues.apache.org/jira/browse/OFBIZ-511
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Assigned To: Jacopo Cappellato
> Priority: Trivial
> Attachments: ofbiz_cast1a.diff
>
>
> Hi,
> this patch removes some casts where the source-type and the casted-to type are identical. Therefore these casts are unnecessary and can/should be removed.