[jira] Created: (OFBIZ-538) Parameterize CommonFacilityDecorator location in FaclityScreens

[Nicolas Malin (Jira)]

Parameterize CommonFacilityDecorator location in FaclityScreens
---------------------------------------------------------------

                 Key: OFBIZ-538
                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Anil K Patel


Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-538?page=all ]

Anil K Patel updated OFBIZ-538:
-------------------------------

    Attachment: ParameterizedCommonFacilityDecoratorLocation.patch

Implements this requirements from this Issue. Migrated Tabbar Menu to xml widget.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12456969 ]
           
Adrian Crum commented on OFBIZ-538:
-----------------------------------

How does it work? It looks like you'll have the decorator location specified in the request parameters. Is that correct?

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12456974 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

let's say now you want to use ViewFacilityInventoryByProduct in a some other component e.g assetmaint in hotdeploy folder.

Define new CommonFacilityDecorator in assetmaint and Then add following line to web.xml file of asssetmaint component.

<context-param>
        <param-name>commonFacilityDecoratorLocation</param-name>
        <param-value>component://assetmaint/widget/facility/CommonScreens.xml</param-value>
        <description>The location of the CommonFacilityDecorator screen to use for this webapp; referred to as a context variable in screen def XML files.</description>
</context-param>

The location of customer decorator is <param-value>component://assetmaint/widget/facility/CommonScreens.xml</param-value> in the above entry.

View entry in controller.xml file of assetmaint component reads

<view-map name="ViewFacilityInventoryByProduct" type="screen" page="component://product/widget/facility/FacilityScreens.xml#ViewFacilityInventoryByProduct"/>

My screen will use decorator from assetmaint component and not from facility component. So now I have a ViewFacilityInventoryByProduct screen without coping it to assetmaint component.

Hope this helps

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12456977 ]
           
Adrian Crum commented on OFBIZ-538:
-----------------------------------

Looks like a great idea! Thanks for the explanation.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12457807 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

Is it possible for somebody to review this patch. I had it discussed on mailing list before creating this Jira issue.

If there are problems with this Idea or the code submitted please comment. This will help us to make our contribution better and will motivate us to do more work that does not directly benifit our clients.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458864 ]
           
Jacques Le Roux commented on OFBIZ-538:
---------------------------------------

Anil,

In case like that please make 2 patches (1 for tab bar, 1 for Parameterized Decorator). It makes commiters job easier ;o)

Thanks

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-538?page=all ]

Jacques Le Roux reassigned OFBIZ-538:
-------------------------------------

    Assignee: Jacques Le Roux

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458865 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

In remember this for Future. Thanks for looking at this patch. Regards

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458866 ]
           
Jacques Le Roux commented on OFBIZ-538:
---------------------------------------

OK, I see FacilityTabBar.ftl was used by old CommonFacilityDecorator, forget my advice.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458867 ]
           
Jacques Le Roux commented on OFBIZ-538:
---------------------------------------

I reviewed this patch and like Adrian it seems a very good idea to me. Nevertheless I will wait at least another commiter opinion before commit it.

Thanks

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458869 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

Jacques,
I had this discussed on dev list before creating Jira Issue. David had commented on that thread. Please refer to following link. I am waiting on this patch to go so I can submit the assetmaint app.

http://mail-archives.apache.org/mod_mbox/incubator-ofbiz-dev/200612.mbox/%3c4579BB09.2020405@...%3e

Regards

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458870 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

http://www.nabble.com/Is-it-ok-to-Parameterize-location-of-Second-level-decorators-like-CommonFacilityDecorator-tf2782078.html#a7762143

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-538?page=all ]

Jacques Le Roux closed OFBIZ-538.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Anil,

I read the thread on Nabble, your patch is in OFBiz revision: 487648.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458948 ]
           
Jacques Le Roux commented on OFBIZ-538:
---------------------------------------

There was a little bug in menu.xml (2 "FindShipment" for In and Out) this is corrected in rev. 487666.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-538?page=comments#action_12458949 ]
           
Anil K Patel commented on OFBIZ-538:
------------------------------------

I read that in you svn comment, Sorry for that, thanks for fixing it.

> Parameterize CommonFacilityDecorator location in FaclityScreens
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-538
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-538
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: ParameterizedCommonFacilityDecoratorLocation.patch
>
>
> Parameterize CommonFacilityDecorator location in FaclityScreens, Just makes it easy to write custom apps.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira