[jira] Created: (OFBIZ-540) Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard

[Nicolas Malin (Jira)]

Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
------------------------------------------------------------------------------------

                 Key: OFBIZ-540
                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: workeffort
            Reporter: Anil K Patel


Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Anil K Patel updated OFBIZ-540:
-------------------------------

    Attachment: WorkEffortScreensAndServices.patch

Implements Services and Screens for Entities mentioned in this issue. Exception is One screen WorkEffortReview is not implemented. If possible please give some details on how this screen should be designed.
 

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Attachments: WorkEffortScreensAndServices.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457167 ]
           
Jacopo Cappellato commented on OFBIZ-540:
-----------------------------------------

Anil,

after a very quick review I've noticed that you have implemented the services to manage WorkEffortGoodStandard entities: however these services (with different names) are already available in OFBiz...

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Attachments: WorkEffortScreensAndServices.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Ashish Vijaywargiya updated OFBIZ-540:
--------------------------------------

    Attachment: Generic_Entity_Screen_2.patch

Hi,

Thanks Jacopo for pointing it out.
Here is the modified patch that uses the existing services of "WorkEffortGoodStandard" entity.

Regards
Ashish Vijaywargiya

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreensAndServices.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Jacopo Cappellato updated OFBIZ-540:
------------------------------------

    Attachment:     (was: WorkEffortScreensAndServices.patch)

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Attachments: Generic_Entity_Screen_2.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457466 ]
           
David E. Jones commented on OFBIZ-540:
--------------------------------------

Just a few comments Ashish/Anil:

- create methods should use a "create" prefix instead of an "add" prefix, and request names that call service should generally use the name of the service (unless there is a conflict or something, then adding context info is good); there are some bad examples in OFBiz, so the place to look for patterns is the example component; for form names the prefix "Add" is fine as we've used the different words to make a distinction between what they are used for; anyway, create matches up with update and delete better

Actually, that was the only one. I haven't tested this yet (not sure if you're done yet or not), but this is certainly going in the right direction.

If this is what you had in mind for a final patch let me know and I'll test and commit. Otherwise I'll wait for your final patch.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Attachments: Generic_Entity_Screen_2.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

David E. Jones reassigned OFBIZ-540:
------------------------------------

    Assignee: David E. Jones

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Anil K Patel updated OFBIZ-540:
-------------------------------

    Attachment: WorkEffortScreenAndServices.patch

This patch has modifications in name of the request map as suggested by David.  Still this patch does not have screen for WorkEffortReview.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreenAndServices.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Anil K Patel updated OFBIZ-540:
-------------------------------

    Attachment: WorkEffortScreenAndServicesUpdate3.patch

Please use this patch. Adds implementation of WorkEffortReview screen.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreenAndServices.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457549 ]
           
Andrew Zeneski commented on OFBIZ-540:
--------------------------------------

What's the status on this patch? Is it ready for prime time or still in progress?

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreenAndServices.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457567 ]
           
Anil K Patel commented on OFBIZ-540:
------------------------------------

The patch added the last is most complete and good to go.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreenAndServices.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457578 ]
           
David E. Jones commented on OFBIZ-540:
--------------------------------------

This patch is a good start, so I'm committing it, but these still needs a few cleanups:

1. there are various Delete button texts with [] around them

2. on the list forms wherever there is an ID that points to an entity with a name field on it, it should also lookup and show that name (using display-entity, make the link with the sub hyperlink tag); these are missing on the WorkEffort->Content, WorkEffort->Good Standard, Content->Work Effort, Product->Work Effort; also on Work Effort->Review the userLoginId should link to the profile page in the Party Manager app using the UserLogin.partyId field, and it should show the party name to using the PartyNameView as is done elsewhere (search for PartyNameView to find examples)

3. the button title for Work Effort -> Good Standard shoud be Product instead of Good Standard (easier for the user, the whole Good Standard thing came from the entity name in the data model resource book)

4. the various *TypeId fields are showing the actual IDs and should show the description from the type table using the display-entity type of field

5. the statusId for the WorkEffortGoodStandard is using the general WorkEffort statuses but should use the statuses for WorkEffortGoodStandard defined in the WorkEffortTypeData.xml file

Okay, I think that's about it. Things look pretty good, even with the test data I have for the client that is sponsoring this.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: Generic_Entity_Screen_2.patch, WorkEffortScreenAndServices.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457581 ]
           
David E. Jones commented on OFBIZ-540:
--------------------------------------

Forgot to mention: the WorkEffortScreenAndServicesUpdate3.patch file is committed in SVN rev 486033.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

David E. Jones updated OFBIZ-540:
---------------------------------

    Attachment:     (was: Generic_Entity_Screen_2.patch)

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

David E. Jones updated OFBIZ-540:
---------------------------------

    Attachment:     (was: WorkEffortScreenAndServices.patch)

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457583 ]
           
Anil K Patel commented on OFBIZ-540:
------------------------------------

I'll soon submit a patch with changes as suggested by you.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

Ashish Vijaywargiya updated OFBIZ-540:
--------------------------------------

    Attachment: WorkEffortScreenAndServices_4.patch

Hi David,

This patch fixes all of your previous comments.

Regards
Ashish Vijaywargiya

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>         Attachments: WorkEffortScreenAndServices_4.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-540?page=all ]

David E. Jones closed OFBIZ-540.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Okay, I think we can now shut the coffin on this one...

I applied this patch in SVN rev 486370 with just a few small changes to make the WorkEffortGoodStandard.statusId optional.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: WorkEffortScreenAndServices_4.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457920 ]
           
Anil K Patel commented on OFBIZ-540:
------------------------------------

David,
Thanks for applying this patch.

> Services and Screens WorkEffortReview, WorkEffortContent, and WorkEffortGoodStandard
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-540
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-540
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: workeffort
>            Reporter: Anil K Patel
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: WorkEffortScreenAndServices_4.patch, WorkEffortScreenAndServicesUpdate3.patch
>
>
> Creat generic administration screens and services for 3 entities that are related to the WorkEffort.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira