[jira] [Created] (OFBIZ-5615) Clean up compiler warning in InvoiceServices

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-5615) Clean up compiler warning in InvoiceServices

Nicolas Malin (Jira)
Paul Foxworthy created OFBIZ-5615:
-------------------------------------

             Summary: Clean up compiler warning in InvoiceServices
                 Key: OFBIZ-5615
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5615
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Paul Foxworthy
            Assignee: Paul Foxworthy
            Priority: Minor


In createInvoicesFromShipment, the variable invoicePerShipment may hold a null if it happens that the invoicePerShipment attribute in the OrderHeader is null. The situation is very unlikely, because the createOrder service sets invoicePerShipment provided there is a valid configuration setting create.invoice.per.shipment .

Still, there is a warning from some compilers and static code analysis tools regarding a possible null value. The patch eliminates the warning.



--
This message was sent by Atlassian JIRA
(v6.2#6252)