[jira] Created: (OFBIZ-612) Order Title i18n

[Nicolas Malin (Jira)]

Order Title i18n
----------------

                 Key: OFBIZ-612
                 URL: https://issues.apache.org/jira/browse/OFBIZ-612
             Project: Apache OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Guido Amarilla
            Priority: Minor


I´ve found some formatting and language errors when generating a Sales
or Purchase Order PDF. I need to know if these are real errors and
should be reported to a JIRA issue or should I customize it to my
needs.

Order Title in English: it is "Sales Order" but in spanish it is
"Venta Orden" which is incorrect and should be "Orden de Venta". This
is because it is being built using two strings: "Sales" + "Order" and
that way of composing this phrase is language specific.
The same happens in a purchase order: "Compra Orden" instead of "Orden
de Compra"

orderReportHeaderInfo.fo.ftl : line 24
<fo:block number-columns-spanned="2"
font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}
${uiLabelMap.OrderOrder}</fo:block>

Solution:
if it is changed to:

<fo:block number-columns-spanned="2"
font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}</fo:block>

and   OrderEntityLabels.properties should be changed from this:

OrderType.description.PURCHASE_ORDER=Purchase
OrderType.description.SALES_ORDER=Sales

to this

OrderType.description.PURCHASE_ORDER=Purchase Order
OrderType.description.SALES_ORDER=Sales Order

(in every language's OrderEntityLabels_XX.properties files)

This change would only affect Order list view. I tested it and it is
not significative, except for the increased column width. The column
"Order Type" uses "Purchase Order" and "Sales Order" for every item,
instead of just "Purchase" or "Sales".

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463728 ]

Guido Amarilla commented on OFBIZ-612:
--------------------------------------

2007/1/10, David E Jones <[hidden email]>:


    Yes, I agree. This looks like an insufficient i18n, and the pattern
    for fixing is fine.

    -David

> Order Title i18n
> ----------------
>
>                 Key: OFBIZ-612
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-612
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Guido Amarilla
>            Priority: Minor
>
> I´ve found some formatting and language errors when generating a Sales
> or Purchase Order PDF. I need to know if these are real errors and
> should be reported to a JIRA issue or should I customize it to my
> needs.
> Order Title in English: it is "Sales Order" but in spanish it is
> "Venta Orden" which is incorrect and should be "Orden de Venta". This
> is because it is being built using two strings: "Sales" + "Order" and
> that way of composing this phrase is language specific.
> The same happens in a purchase order: "Compra Orden" instead of "Orden
> de Compra"
> orderReportHeaderInfo.fo.ftl : line 24
> <fo:block number-columns-spanned="2"
> font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}
> ${uiLabelMap.OrderOrder}</fo:block>
> Solution:
> if it is changed to:
> <fo:block number-columns-spanned="2"
> font-weight="bold">${orderHeader.getRelatedOne("OrderType").get("description",locale)}</fo:block>
> and   OrderEntityLabels.properties should be changed from this:
> OrderType.description.PURCHASE_ORDER=Purchase
> OrderType.description.SALES_ORDER=Sales
> to this
> OrderType.description.PURCHASE_ORDER=Purchase Order
> OrderType.description.SALES_ORDER=Sales Order
> (in every language's OrderEntityLabels_XX.properties files)
> This change would only affect Order list view. I tested it and it is
> not significative, except for the increased column width. The column
> "Order Type" uses "Purchase Order" and "Sales Order" for every item,
> instead of just "Purchase" or "Sales".

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira