OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

A long selectAllForm's table will overlap with addVariantsToVirtual's table
---------------------------------------------------------------------------

Key: OFBIZ-622
URL: https://issues.apache.org/jira/browse/OFBIZ-622
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Environment: Firefox 2.0.0.1
Reporter: Jonathon Wong
Fix For: SVN trunk

Bug in file QuickAddVariants.ftl.

I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.

So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.

This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

[ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathon Wong updated OFBIZ-622:
--------------------------------

Attachment: QuickAddVariants.ftl.patch

> A long selectAllForm's table will overlap with addVariantsToVirtual's table
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-622
> URL: https://issues.apache.org/jira/browse/OFBIZ-622
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: Firefox 2.0.0.1
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: QuickAddVariants.ftl.patch
>
>
> Bug in file QuickAddVariants.ftl.
> I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.
> So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.
> This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464471 ]

Jacques Le Roux commented on OFBIZ-622:
---------------------------------------

Jonathon,

I can't reproduce, please can you give an usecase ? BTW which browser(s) did you use ?

Thanks

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464497 ]

Jonathon Wong commented on OFBIZ-622:
-------------------------------------

Browser is Firefox 2.0.0.1 on WinXP.

You have to create a virtual product with lots and lots of feature types. Then you'll get a very wide selectAllForm.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-622:
--------------------------------

Assignee: Scott Gray

> A long selectAllForm's table will overlap with addVariantsToVirtual's table
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-622
> URL: https://issues.apache.org/jira/browse/OFBIZ-622
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: Firefox 2.0.0.1
> Reporter: Jonathon Wong
> Assigned To: Scott Gray
> Fix For: SVN trunk
>
> Attachments: QuickAddVariants.ftl.patch
>
>
> Bug in file QuickAddVariants.ftl.
> I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.
> So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.
> This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-622.
----------------------------

Resolution: Fixed

Thanks Jonathon, your patch is in with rev. 500936

> A long selectAllForm's table will overlap with addVariantsToVirtual's table
> ---------------------------------------------------------------------------
>
> Key: OFBIZ-622
> URL: https://issues.apache.org/jira/browse/OFBIZ-622
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: Firefox 2.0.0.1
> Reporter: Jonathon Wong
> Assigned To: Scott Gray
> Fix For: SVN trunk
>
> Attachments: QuickAddVariants.ftl.patch
>
>
> Bug in file QuickAddVariants.ftl.
> I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.
> So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.
> This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Tim Ruppert

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

Since this is already in and there are certainly tons of other examples of this - it really doesn't matter, but I just wanted to call attention to something that stuck out to me.

We should do our best not to embed any style attributes into the code as we're in there - as well as doing our best to give classes or ids to divs so that they can be styled more easily in the future.

Thanks for fixing the bug nonetheless, Jonathon.

Cheers,

Tim

Tim Ruppert

HotWax Media

http://www.hotwaxmedia.com

o:801.649.6594

f:801.649.6595

On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:

   [ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-622.
----------------------------

Resolution: Fixed

Thanks Jonathon, your patch is in with rev. 500936

A long selectAllForm's table will overlap with addVariantsToVirtual's table
---------------------------------------------------------------------------

Key: OFBIZ-622
URL: https://issues.apache.org/jira/browse/OFBIZ-622
Project: OFBiz (The Open for Business Project)
   Issue Type: Bug
   Components: product
   Affects Versions: SVN trunk
Environment: Firefox 2.0.0.1
   Reporter: Jonathon Wong
Assigned To: Scott Gray
Fix For: SVN trunk

Attachments: QuickAddVariants.ftl.patch

Bug in file QuickAddVariants.ftl.
I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.
So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.
This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

smime.p7s (3K) Download Attachment

Scott Gray

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

Hi Tim

That's a good point, replacing the styles with class="col" seems to
work, I'll fix it shortly unless anyone wants to point out a better
class to use...

Thanks
Scott

Tim Ruppert wrote:

> Since this is already in and there are certainly tons of other
> examples of this - it really doesn't matter, but I just wanted to call
> attention to something that stuck out to me.
>
> We should do our best not to embed any style attributes into the code
> as we're in there - as well as doing our best to give classes or ids
> to divs so that they can be styled more easily in the future.
>
> Thanks for fixing the bug nonetheless, Jonathon.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
>
> On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Scott Gray closed OFBIZ-622.
>> ----------------------------
>>
>> Resolution: Fixed
>>
>> Thanks Jonathon, your patch is in with rev. 500936
>>
>>> A long selectAllForm's table will overlap with
>>> addVariantsToVirtual's table
>>> ---------------------------------------------------------------------------
>>>
>>> Key: OFBIZ-622
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-622
>>> Project: OFBiz (The Open for Business Project)
>>> Issue Type: Bug
>>> Components: product
>>> Affects Versions: SVN trunk
>>> Environment: Firefox 2.0.0.1
>>> Reporter: Jonathon Wong
>>> Assigned To: Scott Gray
>>> Fix For: SVN trunk
>>>
>>> Attachments: QuickAddVariants.ftl.patch
>>>
>>>
>>> Bug in file QuickAddVariants.ftl.
>>> I switched the position of the <div> containing the
>>> addVariantsToVirtual form to below the selectAllForm form. I also
>>> put the selectAllForm form into a <div style="float: left">.
>>> So there are now 2 <div>s instead 1: the 1st <div> floats left and
>>> contains the selectAllForm, the 2nd <div> floats right as usual and
>>> contains the addVariantsToVirtual form.
>>> This way, if the selectAllForm is not too wide, both forms sit side
>>> by side as usual. Otherwise, the addVariantsToVirtual form gets
>>> bumped down the page.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>

Tim Ruppert

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

Thanks Scott.

On Jan 28, 2007, at 9:49 PM, Scott Gray wrote:

Hi Tim

That's a good point, replacing the styles with class="col" seems to work, I'll fix it shortly unless anyone wants to point out a better class to use...

Thanks
Scott

Tim Ruppert wrote:

Since this is already in and there are certainly tons of other examples of this - it really doesn't matter, but I just wanted to call attention to something that stuck out to me.
We should do our best not to embed any style attributes into the code as we're in there - as well as doing our best to give classes or ids to divs so that they can be styled more easily in the future.

Thanks for fixing the bug nonetheless, Jonathon.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:

   [ https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-622.
----------------------------

Resolution: Fixed

Thanks Jonathon, your patch is in with rev. 500936

A long selectAllForm's table will overlap with addVariantsToVirtual's table
---------------------------------------------------------------------------

Key: OFBIZ-622
URL: https://issues.apache.org/jira/browse/OFBIZ-622
Project: OFBiz (The Open for Business Project)
   Issue Type: Bug
   Components: product
   Affects Versions: SVN trunk
Environment: Firefox 2.0.0.1
   Reporter: Jonathon Wong
Assigned To: Scott Gray
Fix For: SVN trunk

Attachments: QuickAddVariants.ftl.patch

Bug in file QuickAddVariants.ftl.
I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">.
So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form.
This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

smime.p7s (3K) Download Attachment

jonwimp

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Tim Ruppert

Tim,

Argh. Another mistake. (2 from me so far). Shows that we really need resources to audit patches
before check in.

For this particular issue, I did search the maincss.css. But couldn't find a counterpart for style
"boxlink" (float: right). I didn't even know what "boxlink" meant in the first place.

As I was fixing the QuickAddVariants.ftl, I thought to "fix things with a small a footprint of
change as possible". The original <table> containing form "selectAllForm" was a raw table without
CSS styles. I just didn't want to break that tradition in my "fix things using smallest footprint"
principle.

I probably could've used style ".productsummary .smallimage", but that <table> wasn't a small
image. Maybe I could've used style "DIV.boxhead-left", but I wasn't sure that it wouldn't change
the original "selectAllForm" look-and-feel.

And I wasn't gonna add a private JonathonDiv-Left style into maincss.css file.

Maybe the recent re-organization of the maincss.css file will help. We'd need a good document to
explain the use of every CSS style in OFBiz, so we can get everyone to easily fit their UIs into
OFBiz's organized framework (UI aspects of it, ie).

Jonathon

Tim Ruppert wrote:

> Since this is already in and there are certainly tons of other examples
> of this - it really doesn't matter, but I just wanted to call attention
> to something that stuck out to me.
>
> We should do our best not to embed any style attributes into the code as
> we're in there - as well as doing our best to give classes or ids to
> divs so that they can be styled more easily in the future.
>
> Thanks for fixing the bug nonetheless, Jonathon.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
>
> On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Scott Gray closed OFBIZ-622.
>> ----------------------------
>>
>> Resolution: Fixed
>>
>> Thanks Jonathon, your patch is in with rev. 500936
>>
>>> A long selectAllForm's table will overlap with addVariantsToVirtual's
>>> table
>>> ---------------------------------------------------------------------------
>>>
>>> Key: OFBIZ-622
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-622
>>> Project: OFBiz (The Open for Business Project)
>>> Issue Type: Bug
>>> Components: product
>>> Affects Versions: SVN trunk
>>> Environment: Firefox 2.0.0.1
>>> Reporter: Jonathon Wong
>>> Assigned To: Scott Gray
>>> Fix For: SVN trunk
>>>
>>> Attachments: QuickAddVariants.ftl.patch
>>>
>>>
>>> Bug in file QuickAddVariants.ftl.
>>> I switched the position of the <div> containing the
>>> addVariantsToVirtual form to below the selectAllForm form. I also put
>>> the selectAllForm form into a <div style="float: left">.
>>> So there are now 2 <div>s instead 1: the 1st <div> floats left and
>>> contains the selectAllForm, the 2nd <div> floats right as usual and
>>> contains the addVariantsToVirtual form.
>>> This way, if the selectAllForm is not too wide, both forms sit side
>>> by side as usual. Otherwise, the addVariantsToVirtual form gets
>>> bumped down the page.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>

jonwimp

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by Scott Gray

Oh. So there's the class "col" in tabstyles.css. Oops. I was just starting out with OFBiz then,
and didn't know all the styles available (* fending off rotten tomatoes *). :P

I second the use of class "col" in this case. The other styles have widths and/or fonts attached.
I greped maincss.css and tabstyles.css. Please alert me to other .css in use if there are any. Thanks!

Jonathon

Scott Gray wrote:

> Hi Tim
>
> That's a good point, replacing the styles with class="col" seems to
> work, I'll fix it shortly unless anyone wants to point out a better
> class to use...
>
> Thanks
> Scott
>
> Tim Ruppert wrote:
>> Since this is already in and there are certainly tons of other
>> examples of this - it really doesn't matter, but I just wanted to call
>> attention to something that stuck out to me.
>> We should do our best not to embed any style attributes into the code
>> as we're in there - as well as doing our best to give classes or ids
>> to divs so that they can be styled more easily in the future.
>>
>> Thanks for fixing the bug nonetheless, Jonathon.
>>
>> Cheers,
>> Tim
>> --
>> Tim Ruppert
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> o:801.649.6594
>> f:801.649.6595
>>
>>
>> On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Scott Gray closed OFBIZ-622.
>>> ----------------------------
>>>
>>> Resolution: Fixed
>>>
>>> Thanks Jonathon, your patch is in with rev. 500936
>>>
>>>> A long selectAllForm's table will overlap with
>>>> addVariantsToVirtual's table
>>>> ---------------------------------------------------------------------------
>>>>
>>>>
>>>> Key: OFBIZ-622
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-622
>>>> Project: OFBiz (The Open for Business Project)
>>>> Issue Type: Bug
>>>> Components: product
>>>> Affects Versions: SVN trunk
>>>> Environment: Firefox 2.0.0.1
>>>> Reporter: Jonathon Wong
>>>> Assigned To: Scott Gray
>>>> Fix For: SVN trunk
>>>>
>>>> Attachments: QuickAddVariants.ftl.patch
>>>>
>>>>
>>>> Bug in file QuickAddVariants.ftl.
>>>> I switched the position of the <div> containing the
>>>> addVariantsToVirtual form to below the selectAllForm form. I also
>>>> put the selectAllForm form into a <div style="float: left">.
>>>> So there are now 2 <div>s instead 1: the 1st <div> floats left and
>>>> contains the selectAllForm, the 2nd <div> floats right as usual and
>>>> contains the addVariantsToVirtual form.
>>>> This way, if the selectAllForm is not too wide, both forms sit side
>>>> by side as usual. Otherwise, the addVariantsToVirtual form gets
>>>> bumped down the page.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>
>
>

cjhowe

Re: [jira] Closed: (OFBIZ-622) A long selectAllForm's table will overlap with addVariantsToVirtual's table

In reply to this post by jonwimp

Jonathon,

No need to keep a tally, trust me, you'll lose count. If your review
of OFBiz's incompleteness, etc is even half correct, everyone else has
likely lost count of theirs as well. :-)

--- Jonathon -- Improov <[hidden email]> wrote:

> Tim,
>
> Argh. Another mistake. (2 from me so far). Shows that we really need
> resources to audit patches
> before check in.
>
> For this particular issue, I did search the maincss.css. But couldn't
> find a counterpart for style
> "boxlink" (float: right). I didn't even know what "boxlink" meant in
> the first place.
>
> As I was fixing the QuickAddVariants.ftl, I thought to "fix things
> with a small a footprint of
> change as possible". The original <table> containing form
> "selectAllForm" was a raw table without
> CSS styles. I just didn't want to break that tradition in my "fix
> things using smallest footprint"
> principle.
>
> I probably could've used style ".productsummary .smallimage", but
> that <table> wasn't a small
> image. Maybe I could've used style "DIV.boxhead-left", but I wasn't
> sure that it wouldn't change
> the original "selectAllForm" look-and-feel.
>
> And I wasn't gonna add a private JonathonDiv-Left style into
> maincss.css file.
>
> Maybe the recent re-organization of the maincss.css file will help.
> We'd need a good document to
> explain the use of every CSS style in OFBiz, so we can get everyone
> to easily fit their UIs into
> OFBiz's organized framework (UI aspects of it, ie).
>
> Jonathon
>
> Tim Ruppert wrote:
> > Since this is already in and there are certainly tons of other
> examples
> > of this - it really doesn't matter, but I just wanted to call
> attention
> > to something that stuck out to me.
> >
> > We should do our best not to embed any style attributes into the
> code as
> > we're in there - as well as doing our best to give classes or ids
> to
> > divs so that they can be styled more easily in the future.
> >
> > Thanks for fixing the bug nonetheless, Jonathon.
> >
> > Cheers,
> > Tim
> > --
> > Tim Ruppert
> > HotWax Media
> > http://www.hotwaxmedia.com
> >
> > o:801.649.6594
> > f:801.649.6595
> >
> >
> > On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:
> >
> >>
> >> [
> >>
>

https://issues.apache.org/jira/browse/OFBIZ-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

>
> >> ]
> >>
> >> Scott Gray closed OFBIZ-622.
> >> ----------------------------
> >>
> >> Resolution: Fixed
> >>
> >> Thanks Jonathon, your patch is in with rev. 500936
> >>
> >>> A long selectAllForm's table will overlap with
> addVariantsToVirtual's
> >>> table
> >>>
>

---------------------------------------------------------------------------

> >>>
> >>> Key: OFBIZ-622
> >>> URL:
> https://issues.apache.org/jira/browse/OFBIZ-622
> >>> Project: OFBiz (The Open for Business Project)
> >>> Issue Type: Bug
> >>> Components: product
> >>> Affects Versions: SVN trunk
> >>> Environment: Firefox 2.0.0.1
> >>> Reporter: Jonathon Wong
> >>> Assigned To: Scott Gray
> >>> Fix For: SVN trunk
> >>>
> >>> Attachments: QuickAddVariants.ftl.patch
> >>>
> >>>
> >>> Bug in file QuickAddVariants.ftl.
> >>> I switched the position of the <div> containing the
> >>> addVariantsToVirtual form to below the selectAllForm form. I also
> put
> >>> the selectAllForm form into a <div style="float: left">.
> >>> So there are now 2 <div>s instead 1: the 1st <div> floats left
> and
> >>> contains the selectAllForm, the 2nd <div> floats right as usual
> and
> >>> contains the addVariantsToVirtual form.
> >>> This way, if the selectAllForm is not too wide, both forms sit
> side
> >>> by side as usual. Otherwise, the addVariantsToVirtual form gets
> >>> bumped down the page.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >
>
>