OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-64) form-widget text-find new default and hide options

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

22 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-64) form-widget text-find new default and hide options

form-widget text-find new default and hide options
--------------------------------------------------

Key: OFBIZ-64
URL: http://issues.apache.org/jira/browse/OFBIZ-64
Project: The Open For Business Project
Type: Bug

Components: framework
Reporter: Si Chen

Change the <text-find> tag in the form widget:

1. Change the defaults to operation="begins with" and ignore case=true

2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12418349 ]

Daniel Kunkel commented on OFBIZ-64:
------------------------------------

What about making it operation="contains" rather than begins with?

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: The Open For Business Project
> Type: Bug

> Components: framework
> Reporter: Si Chen

>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12418351 ]

Si Chen commented on OFBIZ-64:
------------------------------

Why don't you make a vote on the dev list whether we'd rather have "contains" or "begins with" as the default?

I personally favor "begins with" because a "contains" and a single letter (ie, "a") plus the "ignore case" option could get you a very long and confusing list.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: The Open For Business Project
> Type: Bug

> Components: framework
> Reporter: Si Chen

>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12418362 ]

Daniel Kunkel commented on OFBIZ-64:
------------------------------------

Si

You have a good point. I think contains is better for complicated fields, but the results can be far more confusing an unintuitive.

Thanks

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: The Open For Business Project
> Type: Bug

> Components: framework
> Reporter: Si Chen

>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12418368 ]

BJ Freeman commented on OFBIZ-64:
---------------------------------

I have need, especially with emails to use "does not "
example
get first message in then get a bunch or replys.
so the a does not begin with RE: and contains such and such would get me the first email.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: The Open For Business Project
> Type: Bug

> Components: framework
> Reporter: Si Chen

>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=all ]

Jacopo Cappellato updated OFBIZ-64:
-----------------------------------

Attachment: widget.patch

What do you all think of the change in the widget.patch attachment?
I've changed all the find options (equals, begins, etc...) from radio buttons to options of a select box; in this way the find forms are much more compact.
Can we commit this patch?

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=all ]

Jacopo Cappellato updated OFBIZ-64:
-----------------------------------

Attachment: widget-dtd.patch

In the widget-dtd.patch I've made "begins with" and "ignore case" options the default values.
If you all think it's ok I can apply this patch too.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424285 ]

Jacopo Cappellato commented on OFBIZ-64:
----------------------------------------

I think the if the two patches I've attached to this issue will be committed we could close this issue: in fact I think that the main reason for implementing the ability of selecting the options to display was to make the forms less confusing.
With the select box approach this is addressed.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424289 ]

Hans Bakker commented on OFBIZ-64:
----------------------------------

Did we had the vote on the 'contains' or 'begins with' default?
I would also opt for the contains default....

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424294 ]

Jacques Le Roux commented on OFBIZ-64:
--------------------------------------

I too prefer the contains option. When you search for something you know what you are searching or at least a part of what you are searching. With contains you get a tool for that. I think it's a better default.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=all ]

Si Chen updated OFBIZ-64:
-------------------------

Attachment: ofbiz64-modelform-xsd.patch

Jacopo,

Go ahead and commit it so we could take a look.

I actually worked on a part of it as well--I put changed the defaults in ModelFormField and added "show-options" as part of the XSD. I wonder if you did something like this too?

Si

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424786 ]

Jacopo Cappellato commented on OFBIZ-64:
----------------------------------------

Si,

the show-option is really interesting.
About the new default values, I've noticed that there is no need to modify the ModelFormField method... just change the default value in the xsd file and it will work (this is what I did in my patch).

David, others, can I commit my patches?

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424886 ]

David E. Jones commented on OFBIZ-64:
-------------------------------------

It seems there is general agreement on this, so unless there is a complaint then go for it. I think this is sufficiently discussed and reviewed that nothing needs get in the way of a commit now.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12424895 ]

Si Chen commented on OFBIZ-64:
------------------------------

David,

I'd say go ahead and commit it. Then I'll try to get to the rest of show-options when I have some time.

One thing also: are defaults in ModelFormField method really not needed? In that case, should they be removed? It's a little confusing (at least to me, since I started editing that file) to have them there if the XSD sets the defaults.

Si

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12425146 ]

Jacopo Cappellato commented on OFBIZ-64:
----------------------------------------

Ok,

I've committed my two patches in svn rev. 427905.

Let me know what you think about this.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12425903 ]

Si Chen commented on OFBIZ-64:
------------------------------

Jacopo,

This is very nice!

I still think we should change the ModelFormField defaults just so they are not confusing. If there are no objections I'll commit them.

When I find some free time I'll work on the show/hide options tag.

Si

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12426278 ]

Si Chen commented on OFBIZ-64:
------------------------------

Hey another thing -

Shouldn't the "Begins With", etc. be to the left of the field input, so it reads more like natural text? As in

Find
Group Name [Begins With] ___________

?

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12426316 ]

Jacques Le Roux commented on OFBIZ-64:
--------------------------------------

Yes Si,

This seems a good idea to me too.

Jacques

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12426381 ]

Ashish Vijaywargiya commented on OFBIZ-64:
------------------------------------------

I am agree with Si.
This feature will be really helpful.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-64) form-widget text-find new default and hide options

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-64?page=comments#action_12426785 ]

Si Chen commented on OFBIZ-64:
------------------------------

I made my changes. Let me know if you have any questions. Otherwise I think we can close this issue for now.

> form-widget text-find new default and hide options
> --------------------------------------------------
>
> Key: OFBIZ-64
> URL: http://issues.apache.org/jira/browse/OFBIZ-64
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: framework
> Reporter: Si Chen
> Attachments: ofbiz64-modelform-xsd.patch, widget-dtd.patch, widget.patch
>
>
> Change the <text-find> tag in the form widget:
> 1. Change the defaults to operation="begins with" and ignore case=true
> 2. Implement a new hide-options attribute tag which would hide the choices for doing the text-find, so they are fixed at the default or at the value in the <text-find > tag.