[jira] Created: (OFBIZ-656) when viewing a party you have a link to view the orders for that party but not quotes

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469693 ]

Jacques Le Roux commented on OFBIZ-656:
---------------------------------------

Si,

In https://issues.apache.org/jira/browse/OFBIZ-656#action_12467698 I suggested that to Eric to avoy redundancy.

I'm not sure of what to think here. Because in this case we have more work to extract labels from commonUILabel.properties, for instance
    CommonOrder=Order
    CommonOrders=Orders
    CommonAnyOrderStatus=Any Order Status
    CommonAnyOrderType=Any Order Type
    CommonAnyReturnStatus=Any return status
    CommonNote=Note
    CommonNotes=Notes
there are much more...

And actually if we really want to have an independant framework the commonUILabel.properties file should not even exists or at least not under the framework directory. Perhaps application root might be a good place for such stuffes

What do you think folks ?

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469790 ]

Si Chen commented on OFBIZ-656:
-------------------------------

Let's see what David says.  He's been more involved with separating out the framework and applications.

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469797 ]

eric schwartz commented on OFBIZ-656:
-------------------------------------

i had the labels in the application itself at first. as suggested i moved
the to the common labels file. i will be happy to move the labels anywhere.
let me know if i can be of any help after you guys decide whats best.

Eric Schwartz
Web Developer/IT Department
800.544.8665 ext 273
[hidden email]

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474463 ]

eric schwartz commented on OFBIZ-656:
-------------------------------------

is this going to get commited?

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474807 ]

Si Chen commented on OFBIZ-656:
-------------------------------

It seems that David is busy, so I'll take my guess on this one.  I think that we'd want to keep the applications stuff out of framework, so could you submit a revised patch which:

1.  Adds a <property-map resource="OrderUiLabels" map-name="uiLabelMap" global="true"/> to partymgr/widget/CommonScreens.xml

2.  Uses the order mgr's ui labels in the screens you are modifying?

Thanks.

Si

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475386 ]

eric schwartz commented on OFBIZ-656:
-------------------------------------

also issue 647 is the same as this. one walter posted and one i posted. i am not sure what to do to connect the two issues but this patch is related to both.

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475384 ]

eric schwartz commented on OFBIZ-656:
-------------------------------------

ok a few things to note:

the new attached patch 656.patch includes the changes requested for the labels. it also includes another change to findParty.ftl and partyServices.java. when do a search for a party with postal selected all it returned was the zip code this patch includes the functionlaity to include the city and state. we needed this because say we have 50 parties called classic auto in diffrent states, we need an easy way to distinguish which callsic auto we wanted and by adding city and state info we are able to accomplish that. i cant think of a reason that functionlity should not be commited aswell.

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

eric schwartz updated OFBIZ-656:
--------------------------------

    Attachment: 656.patch

this patch should cover what you requested

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: 656.patch, quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476033 ]

Si Chen commented on OFBIZ-656:
-------------------------------

Eric,

In your modified lookup, what happens if the resulting party has no addresses associated with it?  Just wanted to make sure you've tested that?

Si

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: 656.patch, quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-656.
-------------------------

    Resolution: Fixed

Fixed in SVN r 512823 and 512828

> when viewing a party you have a link to view the orders for that party but not quotes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-656
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-656
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>            Reporter: eric schwartz
>         Assigned To: Si Chen
>            Priority: Minor
>         Attachments: 656.patch, quote_patch_2.txt
>
>
> When you go to find party and lookup a party you will notice in the results there are buttons to view details, orders, and a button to  create an order. what about quotes? there needs to be a button for viewing the quotes for that party found. this is also on issue when viewing a parties profile. you have a menu accross the top with a button to view billing accounts, orders, etc.. but nothing for quotes. the patch i am attaching with this issue adds a button to the view profile screen and the find party search results screen to allow you to view quotes. i may submit a secod patch that will included adding a button to create a new quotes aswell. for now lets start with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.