OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-658) Adding new string utility methods to collapse characters

_‹ Previous Topic Next Topic _›

Classic

List

6 messages Options

Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-658) Adding new string utility methods to collapse characters

Adding new string utility methods to collapse characters
--------------------------------------------------------

Key: OFBIZ-658
URL: https://issues.apache.org/jira/browse/OFBIZ-658
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Joe Eckard
Priority: Trivial
Fix For: SVN trunk
Attachments: patch.txt

Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-658) Adding new string utility methods to collapse characters

[ https://issues.apache.org/jira/browse/OFBIZ-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Eckard updated OFBIZ-658:
-----------------------------

Attachment: patch.txt

> Adding new string utility methods to collapse characters
> --------------------------------------------------------
>
> Key: OFBIZ-658
> URL: https://issues.apache.org/jira/browse/OFBIZ-658
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Joe Eckard
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-658) Adding new string utility methods to collapse characters

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468009 ]

Jacques Le Roux commented on OFBIZ-658:
---------------------------------------

I reviewed this patch sounds fine. I vote for !

> Adding new string utility methods to collapse characters
> --------------------------------------------------------
>
> Key: OFBIZ-658
> URL: https://issues.apache.org/jira/browse/OFBIZ-658
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Joe Eckard
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-658) Adding new string utility methods to collapse characters

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552779 ]

Marco Risaliti commented on OFBIZ-658:
--------------------------------------

Hi Jacques,

they are new methods and they can be committed.
I have not the framework grant to commit but it does not impact on existing code and also I vote for it.

Thanks
Marco

> Adding new string utility methods to collapse characters
> --------------------------------------------------------
>
> Key: OFBIZ-658
> URL: https://issues.apache.org/jira/browse/OFBIZ-658
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Joe Eckard
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-658) Adding new string utility methods to collapse characters

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553794 ]

Jacques Le Roux commented on OFBIZ-658:
---------------------------------------

Thanks for the reminder Marco, and thanks for your patch Joe

At the time I wrote this comment I had not the right to commit in framework and after I forgot this ready to be commited patch. Completed: At revision: 606035

> Adding new string utility methods to collapse characters
> --------------------------------------------------------
>
> Key: OFBIZ-658
> URL: https://issues.apache.org/jira/browse/OFBIZ-658
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Joe Eckard
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-658) Adding new string utility methods to collapse characters

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-658.
---------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

> Adding new string utility methods to collapse characters
> --------------------------------------------------------
>
> Key: OFBIZ-658
> URL: https://issues.apache.org/jira/browse/OFBIZ-658
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Joe Eckard
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: patch.txt
>
>
> Added a method to collapse multiple consecutive identical characters to StringUtil.java (collapseCharacter). Also added to convenience wrapper methods, collapseSpaces and collapseNewlines. (Derived from similar methods in Velocity's StringUtils class)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.