OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-659) Refactoring Create Order process

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

35 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-659) Refactoring Create Order process

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473594 ]

Anil K Patel commented on OFBIZ-659:
------------------------------------

Si,
Can you please give little more specific details on problem you may not noticed. I try my best to keep code organized.
Your comments will help to make it easy for final review.

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473606 ]

Anil K Patel commented on OFBIZ-659:
------------------------------------

Si,
I went back and looked at the modification I have made. I have created few Event handlers, most of the code in them is from the same file. Also while working on this code, I didn't notice any code that shouldn't be in that file. Still I'll appreciate your comments on this code.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473631 ]

Jacopo Cappellato commented on OFBIZ-659:
-----------------------------------------

Anil,

about the supplier drop down in the ship settings page: this is used to assign to a ship group a supplier; this means that the items in that group will be drop shipped (i.e. a purchase order is created for the supplier for these items where the ship to address is the customer's address and not the company's warehouse).

Note: from that screen you can also create new ship groups (using the "create new ship group" link); if in the cart there are more than one ship groups, then a new checkout screen will appear, where you can move the items from one ship group to the other

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473832 ]

Anil K Patel commented on OFBIZ-659:
------------------------------------

Jacopo, Thanks for actively helping me in this process.

OrderEntryCartScreens#ShowCart screen has several ftl files included that are related to Promotions. In case of Purchase Order, I don't see their use. For some reasons (I'll document when I post patch) I have copied this screen and created two more screens, ShowSalesOrderCart, ShowPurchaseOrderCart . I am thinking we can drop including those promotions specific ftl's (promoCodes.ftl, manualPromotions.ftl, promotionsApplied.ftl ) from ShowPurchaseOrderCart. Is this Ok to do or I am missing some functional requirements.
Feedback is much appreciated.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-659:
-------------------------------

Attachment: OrderChekOutProcessRefac.patch

Working on Payment Options screen. I am planning to have a list of Payment Methods and one line item for gift card information, one for EftAccount. Each line Item will have Text box for amount to use from the payment method and a update button to add it to shopping cart.

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492917 ]

Si Chen commented on OFBIZ-659:
-------------------------------

Anil,

Now that we have the release branch I think this is actually something which we should be doing in the main SVN trunk. The old order checkout code could certainly use a lot of enhancing, so if you have the time and interest, this would be a great contribution.

One suggestion that I have is that the ShoppingCart should be more object-oriented. For example, ShoppingCartItem should be sub-classing into FinishedGoodCartItem, DigitalGoodCartItem, RentalCartItem, FinancialAccountCartItem, etc. etc. They should share common methods in ShoppingCartItem but type-specific code such as that for reserving room dates moved into the specific cart item.

Good luck, and thanks for all the contributions!

Si

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-659:
----------------------------------

Assignee: Anil K Patel

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Assignee: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-659:
--------------------------------

Attachment: OrderChekoutProcess.patch

Anil and All
I am working on the refactoring of Order Checkout Process in the Ordermgr for creating 2 different sets of request-map definitions and two different "progress bars", one for sales orders and one for purchase orders as par the description given in this issue.
Here is the first patch from my side.
The refactoring is not complete yet. This is just a starting patch. Here is some info of modifications or additions done in this new patch.
1) Created two different paths for Sales Order and Purchase Order on the application menu.
2) Only Sales Order Path is functional and not the Purchase Order path.
3) Implemented initializeSalesOrder and setOrderCurrencyAgreementShipDates simple methods instead of using Java.
4) Implemented screens to initialize sales order and purchase order.
5) Added new request definitions.
The Sales Order checkout process is functional and can be tested. It doesn't affect the current Checkout Process except a small change in "additem" request-map, which will be removed when I'll submit the next updated patch.
Right now I am wroking to split the ShowCart section for Sales and Purchase Order. I'll Submit the updated patch as soon as I finish it.

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Assignee: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-659) Refactoring Create Order process

In reply to this post by Nicolas Malin (Jira)

> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Assignee: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderCheckoutProcess.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch, OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.