OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-666) maincss.css File Second Pass

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-666) maincss.css File Second Pass

maincss.css File Second Pass
----------------------------

Key: OFBIZ-666
URL: https://issues.apache.org/jira/browse/OFBIZ-666
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Priority: Minor

Converted pt and px to em. Converted color names to hex values. Many thanks to Chris Howe for his help with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-666) maincss.css File Second Pass

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-666:
------------------------------

Attachment: maincss.patch

COMMITTERS: DO NOT COMMIT THIS PATCH RIGHT AWAY! It needs some additional testing.

I have tested this patch with Windows Mozilla, Firefox, and IE 7. I don't have access to a Mac or a *nix machine, so testing needs to be done on those platforms.

Formulas used for conversion:

px * 0.1 = em
pt * 0.1375 = em

This patch makes the UI scalable. At the same time, it makes bad HTML coding glaringly obvious. I fixed one occurrance in the content manager

> maincss.css File Second Pass
> ----------------------------
>
> Key: OFBIZ-666
> URL: https://issues.apache.org/jira/browse/OFBIZ-666
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: maincss.patch
>
>
> Converted pt and px to em. Converted color names to hex values. Many thanks to Chris Howe for his help with this.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468088 ]

Chris Howe commented on OFBIZ-666:
----------------------------------

I would be interested in the answer to the following scenario.

What would the following do?

body {
font-size: 16 px;
font-size: 62.5%;
}

Would this
a) set the font size for the body tag to 16px and then reduce it by 62.5% resulting in 10 px or
b) the 16px definition is ignored and the 62.5% is applied against the user's default font size?

I think it will be b) but if it were a) it would completely eliminate the concern Jacques brought up. I'm not in front of anything I can take a look at. To test the scenario do the following:

body{
font-size: 16px;
font-size:62.5%
}

and then see if there is a difference by changing it to the following:
body{
font-size: 50px;
font-size:62.5%
}

If there is no difference in the way it looks, b) is the manner things are rendered. If how ever they render differently, then a) is the manner things are rendered.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468090 ]

Chris Howe commented on OFBIZ-666:
----------------------------------

on the content manager change, shouldn't that be <h1 | h2> instead of class="head1|head2"?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468134 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

Chris,

The font-size: 62.5%; works well with browser default setting of 16 pt text. It scales well with browser setting changes. If you want to tinker with it, help yourself.

I believe the last property assignment encountered is the one the browser will use. Isn't that the idea of cascading after all?

The problem with <h1 | h2> is the browser appends a new line - not the behavior we want. Again, if you want to tinker with it, help yourself. The patch I provided produces the desired results.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468154 ]

Chris Howe commented on OFBIZ-666:
----------------------------------

confirmed, it's b). Just wishful thinking :)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471486 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

COMMITTERS: Could we get this added to the project please?

It has been tested with Mozilla, Firefox, IE7, and Opera. It has also been tested on Windows and Linux platforms.

There may be some trivial font size differences due to the conversion, but everything still looks pretty much the same.

Once it is committed, I will monitor Jira and the mailing lists closely and fix any problems that crop up.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471970 ]

Jacopo Cappellato commented on OFBIZ-666:
-----------------------------------------

I've applied the patch and I just noticed small changes (and very minor side effects) to the existing layout (but I would have been surprised of the opposite): I vote for it, even if I'm not an expert of css (so I've not really reviewed the patch in terms of css best practices, just from a user point of view).
If there are no objections I could even commit it (within the next few days or before, if we get more positive feedback).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472014 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

Jacopo,

Thank you for reviewing this patch! The patch attempts to get the main CSS file to conform to the CSS Best Practices - http://docs.ofbiz.org/display/OFBADMIN/Best+Practices+Guide .

It would be helpful for me to know what browser and platform you used to evaluate this patch.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472016 ]

Jacopo Cappellato commented on OFBIZ-666:
-----------------------------------------

Sure,

Firefox 2.0.0.1 and Win XP

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472089 ]

Jacopo Cappellato commented on OFBIZ-666:
-----------------------------------------

Adrian, all,

when all this work about css consolidation will be done, one nice think that will happen is that we could simply remove all the styling attributes from the widget form definitions (and just use them when we need a style different from the default one) making them much more readable.
I did some tests in my local copy and it works pretty well.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-666.
-----------------------------------

Resolution: Fixed

Adrian,

your patch is in rev. 505905, thanks.

For all: I've committed this work using a CTR approach in the attempt to get more feedback from others on this and because it is not so dangerous, and it seems to work fine in my box.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-666) maincss.css File Second Pass

Administrator

In reply to this post by Nicolas Malin (Jira)

+1

Jacques

>
> [
https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472089 ]
>
> Jacopo Cappellato commented on OFBIZ-666:
> -----------------------------------------
>
> Adrian, all,
>
> when all this work about css consolidation will be done, one nice think that will happen is that we could simply remove all the
styling attributes from the widget form definitions (and just use them when we need a style different from the default one) making
them much more readable.

> I did some tests in my local copy and it works pretty well.
>
>
> > maincss.css File Second Pass
> > ----------------------------
> >
> > Key: OFBIZ-666
> > URL: https://issues.apache.org/jira/browse/OFBIZ-666
> > Project: OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Components: framework
> > Reporter: Adrian Crum
> > Priority: Minor
> > Attachments: maincss.patch
> >
> >
> > Converted pt and px to em. Converted color names to hex values. Many thanks to Chris Howe for his help with this.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472108 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

Jacopo,

Thank you for committing this patch!

I was thinking exactly the same thing about the widgets - and I am in the process of removing the styling attributes now. Plus, there won't be any need for things like "modelFormField.shouldBeRed" - since you can just style an element with a red text class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472117 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

Jacopo,

I noticed that the content component portion of the patch didn't get committed. This was needed to fix an HTML coding problem that appears when the new style sheet is used.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472118 ]

Jacopo Cappellato commented on OFBIZ-666:
-----------------------------------------

Adrian,

thanks for the reminder and review: the patch is in rev. 506081

PS: are there any other patches attached to other Jira issue that should be committed as part of the css consolidation effort?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-666) maincss.css File Second Pass

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472125 ]

Adrian Crum commented on OFBIZ-666:
-----------------------------------

Jacopo,

Not at this time. I'll post a status update on the dev mailing list tomorrow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.