[jira] Created: (OFBIZ-702) approveOrder is connected to nothing

[Nicolas Malin (Jira)]

approveOrder is connected to nothing
------------------------------------

                 Key: OFBIZ-702
                 URL: https://issues.apache.org/jira/browse/OFBIZ-702
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: ecommerce
            Reporter: Andrew Sykes
            Priority: Minor


From controller.xml...

    <request-map uri="approveOrder">
        <security https="true" direct-request="false"/>
        <event type="java" path="org.ofbiz.order.shoppingcart.CheckOutEvents" invoke="autoApproveOrder"/>
        <response name="success" type="view" value="ordercomplete"/>
    </request-map>

However there is no CheckOutEvents.autoApproveOrder() should this be deleted from controller.xml, or has the functionality been moved/renamed?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-702.
----------------------------

    Resolution: Fixed

Hi Andrew

I checked the ASF svn history and no changes have been made that would have caused this and since the request isn't called anywhere and goes nowhere I've removed it in rev. 505202.

Thanks
Scott

> approveOrder is connected to nothing
> ------------------------------------
>
>                 Key: OFBIZ-702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-702
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Andrew Sykes
>            Priority: Minor
>
> From controller.xml...
>     <request-map uri="approveOrder">
>         <security https="true" direct-request="false"/>
>         <event type="java" path="org.ofbiz.order.shoppingcart.CheckOutEvents" invoke="autoApproveOrder"/>
>         <response name="success" type="view" value="ordercomplete"/>
>     </request-map>
> However there is no CheckOutEvents.autoApproveOrder() should this be deleted from controller.xml, or has the functionality been moved/renamed?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471634 ]

Andrew Sykes commented on OFBIZ-702:
------------------------------------

Thanks Scott, I thought that might be the solution, but I also thought I might be missing something ;-)

> approveOrder is connected to nothing
> ------------------------------------
>
>                 Key: OFBIZ-702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-702
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>            Reporter: Andrew Sykes
>            Priority: Minor
>
> From controller.xml...
>     <request-map uri="approveOrder">
>         <security https="true" direct-request="false"/>
>         <event type="java" path="org.ofbiz.order.shoppingcart.CheckOutEvents" invoke="autoApproveOrder"/>
>         <response name="success" type="view" value="ordercomplete"/>
>     </request-map>
> However there is no CheckOutEvents.autoApproveOrder() should this be deleted from controller.xml, or has the functionality been moved/renamed?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.