[jira] Created: (OFBIZ-713) Asset Maint component Controller Cleanup

[Nicolas Malin (Jira)]

Asset Maint component Controller Cleanup
----------------------------------------

                 Key: OFBIZ-713
                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Anil K Patel


Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-713:
-------------------------------

    Attachment: AssetMaintControllerCleanup.patch

Removed lot of duplicate entries and also deleted facility-controller.xml file, its not needed.

> Asset Maint component Controller Cleanup
> ----------------------------------------
>
>                 Key: OFBIZ-713
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Attachments: AssetMaintControllerCleanup.patch
>
>
> Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-713:
--------------------------------

    Assignee: Scott Gray

> Asset Maint component Controller Cleanup
> ----------------------------------------
>
>                 Key: OFBIZ-713
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Scott Gray
>         Attachments: AssetMaintControllerCleanup.patch
>
>
> Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472073 ]

Scott Gray commented on OFBIZ-713:
----------------------------------

Hi Anil

https://localhost:8443/assetmaint/control/main now loads the main view from workeffort, I assume this is unintended?  Also why have you commented sections out rather than removing them?

Thanks

> Asset Maint component Controller Cleanup
> ----------------------------------------
>
>                 Key: OFBIZ-713
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Scott Gray
>         Attachments: AssetMaintControllerCleanup.patch
>
>
> Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Anil Patel]

Let me update the patch in few mins.
Regards
Anil

On 2/11/07, Scott Gray (JIRA) <[hidden email]> wrote:

>
>
>     [
> https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472073]
>
> Scott Gray commented on OFBIZ-713:
> ----------------------------------
>
> Hi Anil
>
> https://localhost:8443/assetmaint/control/main now loads the main view
> from workeffort, I assume this is unintended?  Also why have you commented
> sections out rather than removing them?
>
> Thanks
>
> > Asset Maint component Controller Cleanup
> > ----------------------------------------
> >
> >                 Key: OFBIZ-713
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
> >             Project: OFBiz (The Open for Business Project)
> >          Issue Type: Improvement
> >            Reporter: Anil K Patel
> >         Assigned To: Scott Gray
> >         Attachments: AssetMaintControllerCleanup.patch
> >
> >
> > Most of the controller entries in AssetMaint controller are from
> Accounting and WorkEffort component controllers. Instead of duplicating
> entries from those controller, we can just include those controller and just
> keep the entries that override behavior for assetmaint component.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-713:
-------------------------------

    Attachment: AssetMaintControllerCleanup.patch

Updated after comments by Scott.

> Asset Maint component Controller Cleanup
> ----------------------------------------
>
>                 Key: OFBIZ-713
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Scott Gray
>         Attachments: AssetMaintControllerCleanup.patch, AssetMaintControllerCleanup.patch
>
>
> Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-713.
----------------------------

    Resolution: Fixed

Thanks Anil, your patch is in with rev. 505862

> Asset Maint component Controller Cleanup
> ----------------------------------------
>
>                 Key: OFBIZ-713
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-713
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Anil K Patel
>         Assigned To: Scott Gray
>         Attachments: AssetMaintControllerCleanup.patch, AssetMaintControllerCleanup.patch
>
>
> Most of the controller entries in AssetMaint controller are from Accounting and WorkEffort component controllers. Instead of duplicating entries from those controller, we can just include those controller and just keep the entries that override behavior for assetmaint component.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.