[jira] Created: (OFBIZ-754) maincss.css File - Third Pass
Locked
[jira] Created: (OFBIZ-754) maincss.css File - Third Pass
 
|
maincss.css File - Third Pass
----------------------------- Key: OFBIZ-754 URL: https://issues.apache.org/jira/browse/OFBIZ-754 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: framework Reporter: Adrian Crum Priority: Minor Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-754) maincss.css File - Third Pass
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-754: ------------------------------ Attachment: maincss.patch > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475283 ] Adrian Crum commented on OFBIZ-754: ----------------------------------- The new classes follow the OFBiz CSS Best Practices. I made some minor changes to the smallSubmit class. The existing comment indicates it is supposed to be used to decorate links to make them look like <form> element submit buttons. But it didn't. So I fixed that. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475284 ] Adrian Crum commented on OFBIZ-754: ----------------------------------- OFBiz maincss.css HTML Element Collection Styles This document describes the new CSS classes and the HTML element collections (or compounds) that they style. Note: [] = style decorators. masthead: <div id="masthead"> <ul> <li> | <li class="logo-area | control-area">Masthead Content</li> </ul> </div> main-navigation: <div id="main-navigation"> <ul> <li> | <li class="disabled | selected">Menu Item</li> </ul> </div> app-navigation: <div id="app-navigation"> <h1 | h2 | h3>Application Title</h1 | h2 | h3> <ul> <li> | <li class="disabled | selected | opposite">Menu Item</li> </ul> </div> screenlet-title-bar: <div class="screenlet-title-bar"> <!-- No menu --> <h1 | h2 | h3>Screenlet Title</h1 | h2 | h3> </div> <div class="screenlet-title-bar"> <!-- With menu --> <ul> <h1 | h2 | h3>Screenlet Title</h1 | h2 | h3> <li> | <li class="disabled">Menu Item</li> </ul> </div> button-bar: <div class="button-bar [button-style-1 | button-style-2 | tool-bar]"> <ul> <li> | <li class="selected">Menu Item</li> </ul> </div> basic-table: <table class="basic-table [hover-bar | dark-grid | light-grid]"> <tr> | <tr class="header-row | alternate-row"> <td> | <td class="button-col | group-label | label"></td> </tr> </table> basic-tree: <ul class="basic-tree"> <li> | <li class="collapsed | expanded">Tree Item</li> <li> <ul class="basic-tree"> ... </ul> </li> </ul> basic-form: <form class="basic-form"> <table class="basic-table [hover-bar | dark-grid | light-grid]"> <tr> | <tr class="header-row | alternate-row"> <td> | <td class="group-label | label"></td> <td><a class="smallSubmit"></a></td> </tr> </table> </form> > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475286 ] Adrian Crum commented on OFBIZ-754: ----------------------------------- Oops, one error in previous comment. basic-form: <form class="basic-form"> <table> <tr> | <tr class="header-row | alternate-row"> <td> | <td class="group-label | label"></td> <td><a class="smallSubmit"></a></td> </tr> </table> </form> > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-754: ------------------------------ Attachment: maincss.patch Better patch. Changed opposite class name to opposed. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-754: ------------------------------ Attachment: maincss.patch More improvements to the new classes. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475965 ] Adrian Crum commented on OFBIZ-754: ----------------------------------- By the way, some of the new classes - like "tool-bar" "required" and "tooltip" - were hastily designed. I'm not a graphics artist. If anyone would like to change their visual appearance to make them better, that would be great. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-754: --------------------------------------- Assignee: Jacopo Cappellato > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-754: ------------------------------ Attachment: maincss.patch A couple of last minute tweaks before this gets committed. I eliminated a couple of unnecessary property assignments in the new classes and added the ability to use the button-bar button styles individually. These changes shouldn't affect any testing that has already been done. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476317 ] Jacopo Cappellato commented on OFBIZ-754: ----------------------------------------- Adrian, got it, thanks. As a side note, I've noticed that the font of the WorkEffort application's screen is slightly different from the one of the other applications: my guess is that there are some conflicts with the special css stylesheet that is loaded by the WorkEffort screens to render the calendar pages. Jacopo > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476319 ] Adrian Crum commented on OFBIZ-754: ----------------------------------- Jacopo, You are correct. Work effort cascades the calendar style sheet - which restyles basic HTML elements. I believe that style sheet was intended to be used in a popup window. I planned on working on the work effort component after I finish Party Manager. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-754: ------------------------------ Attachment: maincss.patch More improvements to the new style sheet. I added the ability to apply the button-bar style to a different HTML compound: <div class="button-bar [button-style-1 | button-style-2 | tool-bar]"> <a>Link 1</a> <a>Link 2</a> </div> You can see how the same class styles two different HTML compounds on the refactored Party Manager's View Profile page. > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-754) maincss.css File - Third Pass
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-754. ----------------------------------- Resolution: Fixed Adrian, many thanks for your work, your patch is in svn with rev. 514097 > maincss.css File - Third Pass > ----------------------------- > > Key: OFBIZ-754 > URL: https://issues.apache.org/jira/browse/OFBIZ-754 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Assigned To: Jacopo Cappellato > Priority: Minor > Attachments: maincss.patch, maincss.patch, maincss.patch, maincss.patch, maincss.patch > > > Third pass on the back office applications style sheet. Existing classes essentially unchanged, new classes added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |