[jira] Created: (OFBIZ-795) HtmlFormRenderer.java improvement

[Nicolas Malin (Jira)]

HtmlFormRenderer.java improvement
---------------------------------

                 Key: OFBIZ-795
                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: htmlformrenderer.patch

Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-795:
------------------------------

    Attachment: htmlformrenderer.patch

> HtmlFormRenderer.java improvement
> ---------------------------------
>
>                 Key: OFBIZ-795
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: htmlformrenderer.patch
>
>
> Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479658 ]

Jacopo Cappellato commented on OFBIZ-795:
-----------------------------------------

Adrian,

is there a particular reason to remove the html comments arounf the javascript code?

-            buffer.append("<!--//");
-            this.appendWhitespace(buffer);

> HtmlFormRenderer.java improvement
> ---------------------------------
>
>                 Key: OFBIZ-795
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: htmlformrenderer.patch
>
>
> Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479742 ]

Adrian Crum commented on OFBIZ-795:
-----------------------------------

David asked me to. He said the comments won't pass strict HTML validation.

> HtmlFormRenderer.java improvement
> ---------------------------------
>
>                 Key: OFBIZ-795
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: htmlformrenderer.patch
>
>
> Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-795:
---------------------------------------

    Assignee: Jacopo Cappellato

> HtmlFormRenderer.java improvement
> ---------------------------------
>
>                 Key: OFBIZ-795
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: htmlformrenderer.patch
>
>
> Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-795.
-----------------------------------

    Resolution: Fixed

Adrian,

your patch is in rev. 516668

> HtmlFormRenderer.java improvement
> ---------------------------------
>
>                 Key: OFBIZ-795
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-795
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: htmlformrenderer.patch
>
>
> Updated the HtmlFormRenderer class to better handle contained lists. This was necessary to correct layout problems when form widgets are used to render menus.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.