[jira] [Created] (OFBIZ-8115) Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-8115) Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse)

Nicolas Malin (Jira)
Jacques Le Roux created OFBIZ-8115:
--------------------------------------

             Summary: Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse)
                 Key: OFBIZ-8115
                 URL: https://issues.apache.org/jira/browse/OFBIZ-8115
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: Trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
            Priority: Minor
             Fix For: Upcoming Branch


At r1758927 I tried to fixe a bunch of closes missing, reported as warnings in Eclipse

Jacopo noticed and reported on dev ML http://markmail.org/message/b4hvzi7foftfq3j5 2 possible issues:
# you are adding a close statement to code that already had the close
statement in the "finally" block; your modification actually introduces a
code pattern that is not correct (if an exception is thrown your close
statement are not executed)
# I suspect that you are closing the socket connection too early
in PcChargeApi

So I reverted r1758927 to check the issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)