[jira] Created: (OFBIZ-823) Improve support for different media types in the ScreenFopPdfViewHandler

[Nicolas Malin (Jira)]

Improve support for different media types in the ScreenFopPdfViewHandler
------------------------------------------------------------------------

                 Key: OFBIZ-823
                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Jacopo Cappellato
            Priority: Minor


Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
The "content-type" attribute set in the controller's view definition is ignored.

What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).

Some of the details:

1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
2) add support for different media types according to the content-type attribute set in the view definition



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481592 ]

Jacques Le Roux commented on OFBIZ-823:
---------------------------------------

Yes I vote for.

There was also this thread about EPL2 in http://www.nabble.com/I-need-to-print-bar-codes-tf3309861.html. It's Zebra proprietary (hé PCL too ;o) but might be interesting one day.

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481632 ]

Andrew Sykes commented on OFBIZ-823:
------------------------------------

Yes, sounds like a really good idea.

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-823:
---------------------------------------

    Assignee: Jacopo Cappellato

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Shere updated OFBIZ-823:
------------------------------

    Attachment: 823_INCOMPLETE.patch

This patch is not complete and some changes are included only to facilitate testing.

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: 823_INCOMPLETE.patch
>
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481753 ]

David Shere commented on OFBIZ-823:
-----------------------------------

Jacopo and I were working on testing this service that works with the new changes that he's written for this issue.  We were running it with the input of "component://order/widget/ordermgr/RequirementScreens.xml#ApprovedProductRequirementsReport", hence the change to the corresponding line in applications/order/webapp/ordermgr/WEB-INF/controller.xml.

I have commented out the lines that refer to the bodyParameters object, because Jacopo says that's not implemented yet in the code.

I'm including this here because debugging it is a little over my head and I want to get input from everyone.

When I run this service, I get this:

---- exception report ----------------------------------------------------------
Service [sendPrintFromScreen] threw an unexpected exception/error
Exception: org.ofbiz.service.GenericServiceException
Message: Service target threw an unexpected exception (null)
---- stack trace ---------------------------------------------------------------
org.ofbiz.service.GenericServiceException: Service target threw an unexpected exception (null)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:103)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:53)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:340)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:221)
java.lang.Thread.run(Thread.java:595)
java.lang.NullPointerException
org.ofbiz.content.email.EmailServices.sendPrintFromScreen(EmailServices.java:941)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:91)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:53)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:340)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
org.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
org.ofbiz.service.job.JobInvoker.run(JobInvoker.java:221)
java.lang.Thread.run(Thread.java:595)

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: 823_INCOMPLETE.patch
>
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-823.
-----------------------------------

    Resolution: Fixed

rev. 519268

> Improve support for different media types in the ScreenFopPdfViewHandler
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-823
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-823
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Jacopo Cappellato
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: 823_INCOMPLETE.patch
>
>
> Right now the ScreenFopPdfViewHandler class can only serve PDF documents out of a screen definition.
> The "content-type" attribute set in the controller's view definition is ignored.
> What I'm proposing is to enhance the class to support at least the PCL and POSTSCRIPT output (because they should be supported by FOP).
> Some of the details:
> 1) rename the class from ScreenFopPdfViewHandler to ScreenFopViewHandler
> 2) add support for different media types according to the content-type attribute set in the view definition

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.