OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-830) Inventory balance for orders with picklists

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-830) Inventory balance for orders with picklists

Inventory balance for orders with picklists
-------------------------------------------

Key: OFBIZ-830
URL: https://issues.apache.org/jira/browse/OFBIZ-830
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Environment: N/A
Reporter: Ray Barlow
Attachments: balance_inventory.patch

I'll break this in to two sections:
1) The balanceInventoryItems service checks to see if any pick lists are associated with the order id etc to exclude them from balancing to stop them appearing on duplicate pick list. The side effect of the current SQL condition is that part shipped orders don't get re-balanced as inventory changes happen.

The scenario is an order for quantity 2 comes in you have 1 QOH so the order sets up 1 available and 1 on backorder. The customer is keen for the product so asks you to ship the first one which you do by splitting the shipment, creating a pick list, packing it and completing the pick list.

You then receive more stock but the existing order will not clear the backorder flag because the SQL condition only checks for not-equals to PICKLIST_CANCELLED, there is a chance this will work IF the inventory reservation picks two different inventoryIds. The attached patch adds not-equals to PICKLIST_PICKED, as this is effectively a closed status for the pick list. I'll commit this if nobody has any objections.

2) The second scenario really relates to the same principle but occurs in a slightly different time line:
You receive the order for a quantity of 2 and again only 1 QOH so the customer asks you to split ship. The order goes to picking and a pick list is generated and the picking packing process starts in the warehouse. But, if before it completes you receive additional stock either through expected goods receipting or even just adjustments after a shelf recount the second item will not come off backorder because their is an active pick list.

The order item will remain on backorder now, even after the pick list is closed, until additional manual intervention occurs, such as using webtools to run the balance routine (not something you want average users doing!) or additional stock changes are made to trigger a balance.

I don't have a solution for this scenario at the moment but wanted to suggest possibly triggering a balance event against orders when pick lists are canceled and also when they are completed in the case were the order is being part shipped. Or do we need to find an alternative way to stop pick lists allocating items that are on backorder?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-830) Inventory balance for orders with picklists

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Barlow updated OFBIZ-830:
-----------------------------

Attachment: balance_inventory.patch

> Inventory balance for orders with picklists
> -------------------------------------------
>
> Key: OFBIZ-830
> URL: https://issues.apache.org/jira/browse/OFBIZ-830
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: balance_inventory.patch
>
>
> I'll break this in to two sections:
> 1) The balanceInventoryItems service checks to see if any pick lists are associated with the order id etc to exclude them from balancing to stop them appearing on duplicate pick list. The side effect of the current SQL condition is that part shipped orders don't get re-balanced as inventory changes happen.
> The scenario is an order for quantity 2 comes in you have 1 QOH so the order sets up 1 available and 1 on backorder. The customer is keen for the product so asks you to ship the first one which you do by splitting the shipment, creating a pick list, packing it and completing the pick list.
> You then receive more stock but the existing order will not clear the backorder flag because the SQL condition only checks for not-equals to PICKLIST_CANCELLED, there is a chance this will work IF the inventory reservation picks two different inventoryIds. The attached patch adds not-equals to PICKLIST_PICKED, as this is effectively a closed status for the pick list. I'll commit this if nobody has any objections.
> 2) The second scenario really relates to the same principle but occurs in a slightly different time line:
> You receive the order for a quantity of 2 and again only 1 QOH so the customer asks you to split ship. The order goes to picking and a pick list is generated and the picking packing process starts in the warehouse. But, if before it completes you receive additional stock either through expected goods receipting or even just adjustments after a shelf recount the second item will not come off backorder because their is an active pick list.
> The order item will remain on backorder now, even after the pick list is closed, until additional manual intervention occurs, such as using webtools to run the balance routine (not something you want average users doing!) or additional stock changes are made to trigger a balance.
> I don't have a solution for this scenario at the moment but wanted to suggest possibly triggering a balance event against orders when pick lists are canceled and also when they are completed in the case were the order is being part shipped. Or do we need to find an alternative way to stop pick lists allocating items that are on backorder?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496827 ]

Jacopo Cappellato commented on OFBIZ-830:
-----------------------------------------

This is interesting... any other comments?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498117 ]

Jacopo Cappellato commented on OFBIZ-830:
-----------------------------------------

Ray, all,

does this patch need more tests before we can commit it?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498145 ]

Ray Barlow commented on OFBIZ-830:
----------------------------------

I applied the patch to my live system when I posted here so from my perspective it is running fine and has been for 2 months.

The second scenario is still an issue and I'm thinking, certainly for now, that the process of triggering a rebalancing against any open lines would be the most appropriate. 95% of the time nothing will happen as most picklists are complete orders and get picked completely so it shouldn't introduce a major overhead. But it would be good to get thoughts on this area.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509043 ]

Jacques Le Roux commented on OFBIZ-830:
---------------------------------------

Should we apply this patch before it is going too old ?

> Inventory balance for orders with picklists
> -------------------------------------------
>
> Key: OFBIZ-830
> URL: https://issues.apache.org/jira/browse/OFBIZ-830
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: balance_inventory.patch
>
>
> I'll break this in to two sections:
> 1) The balanceInventoryItems service checks to see if any pick lists are associated with the order id etc to exclude them from balancing to stop them appearing on duplicate pick list. The side effect of the current SQL condition is that part shipped orders don't get re-balanced as inventory changes happen.
> The scenario is an order for quantity 2 comes in you have 1 QOH so the order sets up 1 available and 1 on backorder. The customer is keen for the product so asks you to ship the first one which you do by splitting the shipment, creating a pick list, packing it and completing the pick list.
> You then receive more stock but the existing order will not clear the backorder flag because the SQL condition only checks for not-equals to PICKLIST_CANCELLED, there is a chance this will work IF the inventory reservation picks two different inventoryIds. The attached patch adds not-equals to PICKLIST_PICKED, as this is effectively a closed status for the pick list. I'll commit this if nobody has any objections.
> 2) The second scenario really relates to the same principle but occurs in a slightly different time line:
> You receive the order for a quantity of 2 and again only 1 QOH so the customer asks you to split ship. The order goes to picking and a pick list is generated and the picking packing process starts in the warehouse. But, if before it completes you receive additional stock either through expected goods receipting or even just adjustments after a shelf recount the second item will not come off backorder because their is an active pick list.
> The order item will remain on backorder now, even after the pick list is closed, until additional manual intervention occurs, such as using webtools to run the balance routine (not something you want average users doing!) or additional stock changes are made to trigger a balance.
> I don't have a solution for this scenario at the moment but wanted to suggest possibly triggering a balance event against orders when pick lists are canceled and also when they are completed in the case were the order is being part shipped. Or do we need to find an alternative way to stop pick lists allocating items that are on backorder?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509048 ]

Ray Barlow commented on OFBIZ-830:
----------------------------------

OK I will apply later seeing as there are no objections. I will leave this issue open for the second scenario is still to be dealt with, although I will likely down the priority.

> Inventory balance for orders with picklists
> -------------------------------------------
>
> Key: OFBIZ-830
> URL: https://issues.apache.org/jira/browse/OFBIZ-830
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: balance_inventory.patch
>
>
> I'll break this in to two sections:
> 1) The balanceInventoryItems service checks to see if any pick lists are associated with the order id etc to exclude them from balancing to stop them appearing on duplicate pick list. The side effect of the current SQL condition is that part shipped orders don't get re-balanced as inventory changes happen.
> The scenario is an order for quantity 2 comes in you have 1 QOH so the order sets up 1 available and 1 on backorder. The customer is keen for the product so asks you to ship the first one which you do by splitting the shipment, creating a pick list, packing it and completing the pick list.
> You then receive more stock but the existing order will not clear the backorder flag because the SQL condition only checks for not-equals to PICKLIST_CANCELLED, there is a chance this will work IF the inventory reservation picks two different inventoryIds. The attached patch adds not-equals to PICKLIST_PICKED, as this is effectively a closed status for the pick list. I'll commit this if nobody has any objections.
> 2) The second scenario really relates to the same principle but occurs in a slightly different time line:
> You receive the order for a quantity of 2 and again only 1 QOH so the customer asks you to split ship. The order goes to picking and a pick list is generated and the picking packing process starts in the warehouse. But, if before it completes you receive additional stock either through expected goods receipting or even just adjustments after a shelf recount the second item will not come off backorder because their is an active pick list.
> The order item will remain on backorder now, even after the pick list is closed, until additional manual intervention occurs, such as using webtools to run the balance routine (not something you want average users doing!) or additional stock changes are made to trigger a balance.
> I don't have a solution for this scenario at the moment but wanted to suggest possibly triggering a balance event against orders when pick lists are canceled and also when they are completed in the case were the order is being part shipped. Or do we need to find an alternative way to stop pick lists allocating items that are on backorder?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-830) Inventory balance for orders with picklists

In reply to this post by Nicolas Malin (Jira)

> Inventory balance for orders with picklists
> -------------------------------------------
>
> Key: OFBIZ-830
> URL: https://issues.apache.org/jira/browse/OFBIZ-830
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Priority: Minor
> Attachments: balance_inventory.patch
>
>
> I'll break this in to two sections:
> 1) The balanceInventoryItems service checks to see if any pick lists are associated with the order id etc to exclude them from balancing to stop them appearing on duplicate pick list. The side effect of the current SQL condition is that part shipped orders don't get re-balanced as inventory changes happen.
> The scenario is an order for quantity 2 comes in you have 1 QOH so the order sets up 1 available and 1 on backorder. The customer is keen for the product so asks you to ship the first one which you do by splitting the shipment, creating a pick list, packing it and completing the pick list.
> You then receive more stock but the existing order will not clear the backorder flag because the SQL condition only checks for not-equals to PICKLIST_CANCELLED, there is a chance this will work IF the inventory reservation picks two different inventoryIds. The attached patch adds not-equals to PICKLIST_PICKED, as this is effectively a closed status for the pick list. I'll commit this if nobody has any objections.
> 2) The second scenario really relates to the same principle but occurs in a slightly different time line:
> You receive the order for a quantity of 2 and again only 1 QOH so the customer asks you to split ship. The order goes to picking and a pick list is generated and the picking packing process starts in the warehouse. But, if before it completes you receive additional stock either through expected goods receipting or even just adjustments after a shelf recount the second item will not come off backorder because their is an active pick list.
> The order item will remain on backorder now, even after the pick list is closed, until additional manual intervention occurs, such as using webtools to run the balance routine (not something you want average users doing!) or additional stock changes are made to trigger a balance.
> I don't have a solution for this scenario at the moment but wanted to suggest possibly triggering a balance event against orders when pick lists are canceled and also when they are completed in the case were the order is being part shipped. Or do we need to find an alternative way to stop pick lists allocating items that are on backorder?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.