[jira] Created: (OFBIZ-836) Bug in SqlJdbcUtil.java regarding outer join in oracle theta join mode

[Nicolas Malin (Jira)]

Bug in SqlJdbcUtil.java regarding outer join in oracle theta join mode
----------------------------------------------------------------------

                 Key: OFBIZ-836
                 URL: https://issues.apache.org/jira/browse/OFBIZ-836
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: framework
            Reporter: Mamdouh Kaadan


There is a problem in SqlJdbcUtil.java class regarding outer join in oracle, becase the (+) sould be in the end of the Left/Right hand not in the first

The following line (number: 344):
if (isOracleStyle && viewLink.isRelOptional()) whereString.append(" (+) ");

Should be placed after the following lines:
whereString.append(viewLink.getRelEntityAlias());
                        whereString.append(".");
                        whereString.append(filterColName(relLinkField.getColName()));

as the patch in the attached file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mamdouh Kaadan updated OFBIZ-836:
---------------------------------

    Attachment: change.patch

Patch regarding SqlJdbcUtil.java

> Bug in SqlJdbcUtil.java regarding outer join in oracle theta join mode
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-836
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-836
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>            Reporter: Mamdouh Kaadan
>         Attachments: change.patch
>
>
> There is a problem in SqlJdbcUtil.java class regarding outer join in oracle, becase the (+) sould be in the end of the Left/Right hand not in the first
> The following line (number: 344):
> if (isOracleStyle && viewLink.isRelOptional()) whereString.append(" (+) ");
> Should be placed after the following lines:
> whereString.append(viewLink.getRelEntityAlias());
>                         whereString.append(".");
>                         whereString.append(filterColName(relLinkField.getColName()));
> as the patch in the attached file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527700 ]

Jacopo Cappellato commented on OFBIZ-836:
-----------------------------------------

Are we sure about this? We have some customers running OFBiz with Oracle and they have never reported this bug.
Is there a quick way to recreate it?
Which Oracle version and JDBC driver (and its version) are you using?

> Bug in SqlJdbcUtil.java regarding outer join in oracle theta join mode
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-836
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-836
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Mamdouh Kaadan
>         Attachments: change.patch
>
>
> There is a problem in SqlJdbcUtil.java class regarding outer join in oracle, becase the (+) sould be in the end of the Left/Right hand not in the first
> The following line (number: 344):
> if (isOracleStyle && viewLink.isRelOptional()) whereString.append(" (+) ");
> Should be placed after the following lines:
> whereString.append(viewLink.getRelEntityAlias());
>                         whereString.append(".");
>                         whereString.append(filterColName(relLinkField.getColName()));
> as the patch in the attached file

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.