[jira] [Created] (OFBIZ-9254) Inconsistent String Comparisons

[Nicolas Malin (Jira)]

Devanshu Vyas created OFBIZ-9254:
------------------------------------

             Summary: Inconsistent String Comparisons
                 Key: OFBIZ-9254
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9254
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: Trunk
            Reporter: Devanshu Vyas
            Priority: Minor


I found an inconsistency in the code for string comparison statusId.equals("PRUN_COMPLETED") whereas it should be written as "PRUN_COMPLETED".equals(statusId)
cause the former can throw NullPointerException if the variable found to be NULL.

This pattern should be applied to
- Java Files
- Groovy Files
- FTL Files

Here is the reference for the discussion done on the dev list.
http://markmail.org/message/iqfaab3fl3ukxchy



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)