[jira] Created: (OFBIZ-943) Cannot complete order that contains products of type "SERVICE"

[Nicolas Malin (Jira)]

Cannot complete order that contains products of type "SERVICE"
--------------------------------------------------------------

                 Key: OFBIZ-943
                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order, product
    Affects Versions: SVN trunk
            Reporter: Krzysztof Podejma


additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Krzysztof Podejma updated OFBIZ-943:
------------------------------------

        Fix Version/s: Release Branch 4.0
                       SVN trunk
    Affects Version/s: Release Branch 4.0

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk, Release Branch 4.0
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Krzysztof Podejma updated OFBIZ-943:
------------------------------------

    Attachment: invoiceServiceItems.patch

I have written a service to autoinvoice service items for an order.
so now invoice is created.

see my patch for more info

Krzysztof Podejma

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503904 ]

David E. Jones commented on OFBIZ-943:
--------------------------------------

To clarify: just because seed data exists doesn't mean it has been implemented. This appears to be a case where it is has not been implemented, therefore it is a new feature.

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones updated OFBIZ-943:
---------------------------------

    Fix Version/s:     (was: Release Branch 4.0)
       Issue Type: New Feature  (was: Bug)

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503903 ]

David E. Jones commented on OFBIZ-943:
--------------------------------------

Quick comment: this appears to be a new feature and should therefore not go into the release branch (given that the goal of the release branch is stabilization, not progress).

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503910 ]

Krzysztof Podejma commented on OFBIZ-943:
-----------------------------------------

Thanks for clarification. I just share.
Anyway I have found next possible bug. When you have more than one invoice in order and receive offline payment, this payment is applied to first invoice only. It is related to this issue because of services that create invoices.(one invoice is created for each type of product item).
Should I create new issue for this?

Krzysztof

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503933 ]

David E. Jones commented on OFBIZ-943:
--------------------------------------

Thanks Krzysztof, this is great stuff.

Yes, I think that makes very good sense as a separate issue.

Whether that's a bug or a missing feature is a good question, but it seems a basic enough part of operations that we should consider it a bug, meaning it goes into the release branch, etc.

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503955 ]

Krzysztof Podejma commented on OFBIZ-943:
-----------------------------------------

created https://issues.apache.org/jira/browse/OFBIZ-1078

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-943:
----------------------------------

    Affects Version/s:     (was: Release Branch 4.0)

Should not go in release 4.0, see David's comment

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Krzysztof Podejma
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-943.
---------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Krzysztof,

Your patch is in trunk rev. revision: 722588, with some demo data (Services categories and a SERVICE type product)

> Cannot complete order that contains products of type "SERVICE"
> --------------------------------------------------------------
>
>                 Key: OFBIZ-943
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-943
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Krzysztof Podejma
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: invoiceServiceItems.patch
>
>
> additionally no invoices are created after payments are received

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.