[jira] [Created] (OFBIZ-9504) [FB] Package org.apache.ofbiz.accounting.finaccount

[Nicolas Malin (Jira)]

Kyra Pritzel-Hentley created OFBIZ-9504:
-------------------------------------------

             Summary: [FB] Package org.apache.ofbiz.accounting.finaccount
                 Key: OFBIZ-9504
                 URL: https://issues.apache.org/jira/browse/OFBIZ-9504
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
    Affects Versions: Trunk
            Reporter: Kyra Pritzel-Hentley
            Priority: Minor


FinAccountPaymentServices.java:72, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
* RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced in org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, Map)
A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)