[jira] Created: (OFBIZ-966) Enhanced Email Validation in UtilValidate.java

[Nicolas Malin (Jira)]

Enhanced Email Validation in UtilValidate.java
----------------------------------------------

                 Key: OFBIZ-966
                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 4.0
            Reporter: AmitPatidar
            Priority: Minor
             Fix For: Release Branch 4.0


Hello,

I have found a bug in email address field that it accepts "amit@" string as a valid email address.
I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
Now the above email address field value is not a valid email address.

Thanks and Regards.
Amit Patidar.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

AmitPatidar updated OFBIZ-966:
------------------------------

    Attachment: EmailValidation_patch.txt

Enhanced Email Validation in "UtilValidate.java"

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-966:
---------------------------------------

    Assignee: Jacopo Cappellato

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518676 ]

Christian Geisert commented on OFBIZ-966:
-----------------------------------------

I just tested this patch and it works (branch and trunk)

(But I think we should replace this with a regex or maybe commons validator as there cases which it doesn't catch like 'mail@.')

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518786 ]

Ray Barlow commented on OFBIZ-966:
----------------------------------

See also this issue : https://issues.apache.org/jira/browse/OFBIZ-668

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-966.
---------------------------------

    Resolution: Duplicate

I agree with Ray, I think that we should better use org.apache.commons.validator as suggested by John Martin in OFBIZ-668

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-966:
-------------------------------------

    Assignee: Jacques Le Roux  (was: Jacopo Cappellato)

> Enhanced Email Validation in UtilValidate.java
> ----------------------------------------------
>
>                 Key: OFBIZ-966
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-966
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0
>            Reporter: AmitPatidar
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: EmailValidation_patch.txt
>
>
> Hello,
> I have found a bug in email address field that it accepts "amit@" string as a valid email address.
> I have added code in "isEmail()" method of "UtilValidate.java" to fix this bug.
> Now the above email address field value is not a valid email address.
> Thanks and Regards.
> Amit Patidar.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.