[jira] Created: (OFBIZ-976) OrderPrintForms.xml file is renamed to OrderPrintScreens.xml

[Nicolas Malin (Jira)]

OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
------------------------------------------------------------

                 Key: OFBIZ-976
                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting, ecommerce, order, product
            Reporter: vikas mayur
            Priority: Minor


The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
Rename the file to OrderPrintScreens.xml + other changes

Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

vikas mayur updated OFBIZ-976:
------------------------------

    Attachment: OrderPrintScreensPatch.txt

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: vikas mayur
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

vikas mayur updated OFBIZ-976:
------------------------------

    Attachment: OrderPrintScreensPatch.txt

Please consider this patch as i forget to tick " Grant license to ASF for inclusion in ASF works (as per the Apache Software License §5) "

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: vikas mayur
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494824 ]

Anil K Patel commented on OFBIZ-976:
------------------------------------

Vikas,
I think you forgot to include OrderPrintScreens.xml file in your patch.

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: Vikas Mayur
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-976:
------------------------------

    Attachment: OrderPrintScreensPatch.txt

Anil,
Thanks for viewing and commenting out the mistakes.
Attaching the corrected patch.

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: Vikas Mayur
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-976:
---------------------------------------

    Assignee: Jacopo Cappellato

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: Vikas Mayur
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-976.
-----------------------------------

    Resolution: Fixed

Thanks Vikas,

your patch is in rev. 539723

> OrderPrintForms.xml file is renamed to OrderPrintScreens.xml
> ------------------------------------------------------------
>
>                 Key: OFBIZ-976
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-976
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting, ecommerce, order, product
>            Reporter: Vikas Mayur
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt, OrderPrintScreensPatch.txt
>
>
> The naming convention says that *Forms.xml contains forms and *Screens.xml contains screens.
> This file ( OrderPrintForms.xml ) contains screen tags but by name it appears that it is a form file.
> Rename the file to OrderPrintScreens.xml + other changes
> Vikas Mayur

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.