[
https://issues.apache.org/jira/browse/OFBIZ-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suraj Khurana reopened OFBIZ-7272:
----------------------------------
Assignee: Suraj Khurana (was: Arun Patidar)
Re-opening as there are few more classes to be taken care of:
{code:java}
- BillingAccountWorker
- FinAccountHelper
- ConfigXMLReader
- LoginWorker
- ExpressionUiHelper
- JobUtil
- ServiceGroupReader
- ExternalLoginKeysManager
- JWTManager{code}
Will create suitable child tickets and move ahead with these.
> Enforce noninstantiability to all Utility classes
> -------------------------------------------------
>
> Key: OFBIZ-7272
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7272> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Trunk
> Reporter: Rishi Solanki
> Assignee: Suraj Khurana
> Priority: Major
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7272.patch
>
>
> I have discusses this in past on mailing list, that Utility, helper, worker classes which contains only static methods should not be instantiable. Also we can restrict it by adding a private constructor.
> Currently OFBiz has many such classes which should have private constructor. Identify all the *Worker.java, *.Helper.java, and *Util.java which do not have any non static method/member are eligible for having a private constructor.
> Reference why we should do this :
http://www.informit.com/articles/article.aspx?p=1216151&seqNum=4--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
