[jira] [Resolved] (OFBIZ-7091) Two empty options are shown in shipping method select box on Edit promo screen

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey resolved OFBIZ-7091.
----------------------------------
    Resolution: Fixed

Thanks Swapnil M Mane for the contribution. Your patch committed in trunk at revision 1744904.

> Two empty options are shown in shipping method select box on Edit promo screen
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7091
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7091
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Swapnil M Mane
>            Assignee: Pranay Pandey
>            Priority: Trivial
>         Attachments: EditProductPromoRules.png, OFBIZ-7091.patch, OFBIZ-7091.patch
>
>
> On Edit promo screen, in existing condition section's select box two empty options are shown.
> Please find the screenshot for more detail.
> Reason and Solution:
> As per the code in EditProductPromoRules.ftl,
> {code}
> <option value = "${carrierShippingMethod!}">${carrierParty!}&nbsp;${description}</option
> <option value = "">&nbsp;</option>
> {code}
> And the carrierParty is calculated above, if it is not available the first option will show automatically as empty option
> {code}
> <option value = "${carrierShippingMethod!}">${carrierParty!}&nbsp;${description}</option>
> {code}
> So, we don't need the second empty option field and can remove it.
> {code}
> <option value = "">&nbsp;</option>
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)