[jira] [Updated] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-12061:
------------------------------------
    Sprint: OFBiz Community Day (Nov 2020)

> Comment out HideUtilityClassConstructor in checkstyle.xml
> ---------------------------------------------------------
>
>                 Key: OFBIZ-12061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12061
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor."
> This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
> I don't think we need to follow the "prevents calls from subclass" suggestion  there.
> I rather suggest to comment out the related class in checkstyle.xml:
> bq. ie <!-- <module name="HideUtilityClassConstructor"/> -->
> Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)