[jira] [Updated] (OFBIZ-3537) Not all sales invoice item types are showing in listInvoiceItems screen

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar updated OFBIZ-3537:
--------------------------------
    Attachment: OFBIZ-13.07-3537.patch
                OFBIZ_3537.patch

Hello,

Attached two patches for fixing issue in release branch 13.07 and trunk.

Steps to test:
1. Go to Accounting -> Invoices https://localhost:8443/ar/control/findInvoices
2. Click on Create Invoice
3. Add new invoice item
4. Observe 'Invoice Item Type'  drop down, it shows all invoiceItem

Expected behavior: Invoice item type should be display as per selected invoice typeId

> Not all sales invoice item types are showing in listInvoiceItems screen
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Willem Janssen
>            Assignee: Ashish Vijaywargiya
>         Attachments: InvoiceItemType.txt, OFBIZ-13.07-3537.patch, OFBIZ-3537.patch, OFBIZ_3537.patch, invoiceitemtypes.diff
>
>
> Hello,
> In the listInvoiceItems screen, in the 'Invoice Item Type' dropdown item types are missing.
> In the GetInvoiceItemTypes.groovy file the query on the InvoiceItemType entity does not look for item types with:
> - invoiceItemTypeId = SINVOICE_HEAD_ADJ
> - parenttypeId = SINVOICE_HEAD_ADJ
> - invoiceItemTypeId = SINVOICE_ITM_ADJ
> - parenttypeId = SINVOICE_ITM_ADJ
> and the invoice item types that are missing answer the above parameters.
> The patch adds these parameters to the groovy file.
> This seems to be a solutions that's not finished yet, because the splitting of item types between Purchase and Sales invoice item types looks uncompleted. On the one hand there is a parentItemType PINVOICE_ADJ, but there's no SINVOICE_ADJ. Same goes for PINV_PROD_ITEM and no SINV_PROD_ITEM. And there's a SINVOICE_HEAD_ADJ, but no PINVOICE_HEAD_ADJ.
> If somebody can tell me which invoiceitemtypes should be grouped in which parenttypes I'd be happy to make a patch for that...

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)