OFBiz › OFBiz - Dev

[jira] [Updated] (OFBIZ-5189) Portal page personalization is not working

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

1 message

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-5189) Portal page personalization is not working

[ https://issues.apache.org/jira/browse/OFBIZ-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Heintz updated OFBIZ-5189:
----------------------------------

Description:
Two simples errors after last change from FastList to standard java List :
1) go to example component / Dasboard
1.1) click on edit for one page
Screen is blocked
reason :
{code}
for (GenericValue portalPage : portalPages) {
cond = EntityCondition.makeCondition(UtilMisc.toList(
EntityCondition.makeCondition("ownerUserLoginId", EntityOperator.EQUALS, userLoginId),
EntityCondition.makeCondition("originalPortalPageId", EntityOperator.EQUALS, portalPage.getString("portalPageId"))),
EntityOperator.AND);
List <GenericValue> privatePortalPages = delegator.findList("PortalPage", cond, null, null, null, false);
if (UtilValidate.isNotEmpty(privatePortalPages)) {
portalPages.remove(portalPage);
portalPages.add(privatePortalPages.get(0));
}
}
{code}
code iterate on a list and modify it, I don't know how it works before ;-)
I propose to use an other list on iterate

2) on appbarclose.ftl for tomawak theme there is
{code}
<#assign portalPage = delegator.findOne("PortalPage", findMap, true)>
{code}
when you click to "revert to original" in dasboard screen
{code}
Error on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl delegator.findOne("PortalPage", findMap, true) is undefined. It cannot be assigned to portalPage The problematic instruction: ---------- ==> assignment: portalPage=delegator.findOne("PortalPage", findMap, true) [on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl] -
{code}
2.1) to see the error, modify ExampleMenus.xml and change menu-item name from "Dasboard" to "Dasboard1"
2.2) go to example / dashboard and edit one page
2.3) click to "revert to original"
I propose to add ?if_exists

was:
Two simples errors after last change from FastList to standard java List :
1) go to example component / Dasboard
1.1) click on edit for one page
Screen is blocked
reason :
{{code}}
for (GenericValue portalPage : portalPages) {
cond = EntityCondition.makeCondition(UtilMisc.toList(
EntityCondition.makeCondition("ownerUserLoginId", EntityOperator.EQUALS, userLoginId),
EntityCondition.makeCondition("originalPortalPageId", EntityOperator.EQUALS, portalPage.getString("portalPageId"))),
EntityOperator.AND);
List <GenericValue> privatePortalPages = delegator.findList("PortalPage", cond, null, null, null, false);
if (UtilValidate.isNotEmpty(privatePortalPages)) {
portalPages.remove(portalPage);
portalPages.add(privatePortalPages.get(0));
}
}
{{code}}
code iterate on a list and modify it, I don't know how it works before ;-)
I propose to use an other list on iterate

2) on appbarclose.ftl for tomawak theme there is
{{code}}
<#assign portalPage = delegator.findOne("PortalPage", findMap, true)>
{{code}}
when you click to "revert to original" in dasboard screen
{{code}}
Error on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl delegator.findOne("PortalPage", findMap, true) is undefined. It cannot be assigned to portalPage The problematic instruction: ---------- ==> assignment: portalPage=delegator.findOne("PortalPage", findMap, true) [on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl] -
{{code}}
2.1) to see the error, modify ExampleMenus.xml and change menu-item name from "Dasboard" to "Dasboard1"
2.2) go to example / dashboard and edit one page
2.3) click to "revert to original"
I propose to add ?if_exists

> Portal page personalization is not working
> ------------------------------------------
>
> Key: OFBIZ-5189
> URL: https://issues.apache.org/jira/browse/OFBIZ-5189
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: trunk
> Reporter: Olivier Heintz
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5189.patch
>
>
> Two simples errors after last change from FastList to standard java List :
> 1) go to example component / Dasboard
> 1.1) click on edit for one page
> Screen is blocked
> reason :
> {code}
> for (GenericValue portalPage : portalPages) {
> cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("ownerUserLoginId", EntityOperator.EQUALS, userLoginId),
> EntityCondition.makeCondition("originalPortalPageId", EntityOperator.EQUALS, portalPage.getString("portalPageId"))),
> EntityOperator.AND);
> List <GenericValue> privatePortalPages = delegator.findList("PortalPage", cond, null, null, null, false);
> if (UtilValidate.isNotEmpty(privatePortalPages)) {
> portalPages.remove(portalPage);
> portalPages.add(privatePortalPages.get(0));
> }
> }
> {code}
> code iterate on a list and modify it, I don't know how it works before ;-)
> I propose to use an other list on iterate
> 2) on appbarclose.ftl for tomawak theme there is
> {code}
> <#assign portalPage = delegator.findOne("PortalPage", findMap, true)>
> {code}
> when you click to "revert to original" in dasboard screen
> {code}
> Error on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl delegator.findOne("PortalPage", findMap, true) is undefined. It cannot be assigned to portalPage The problematic instruction: ---------- ==> assignment: portalPage=delegator.findOne("PortalPage", findMap, true) [on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl] -
> {code}
> 2.1) to see the error, modify ExampleMenus.xml and change menu-item name from "Dasboard" to "Dasboard1"
> 2.2) go to example / dashboard and edit one page
> 2.3) click to "revert to original"
> I propose to add ?if_exists

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira