[jira] [Updated] (OFBIZ-5255) Error in fieldlookup.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-5255) Error in fieldlookup.js

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-5255:
---------------------------------
    Assignee:     (was: Pranay Pandey)

I checked it on 12.04, the given code snippet as well didn't make any difference. It works with existing code base without any error.

If Skip can supply more details, it can be helpful or I think we can close it.

> Error in fieldlookup.js
> -----------------------
>
>                 Key: OFBIZ-5255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Release Branch 12.04
>         Environment: All
>            Reporter: Skip Dever
>            Priority: Minor
>
> On line 221 in fieldlookup.js is the statement:
> if (ajaxurl != "" && showDescription != "")
> This logic is incorrect because showDescription is normally a boolean and if you pass showDescription="false" to the macro, showDescription != "" evaluates to false.
> I am not sure what the author was trying to test for, but I modified it to either comment out showDescription != "", or change it to:
> if (ajaxurl != "" && !(showDescription === ""))
> The author needs to test this with a macro that passes showDescription="false".  For example, in ordermgr\entry\checkinits.ftl, modify line 104 and add showDescription="false" as a macro argument.  
> Doing so will disable the autocompletion until a modification is made to fieldlookup.js as above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)