[jira] [Updated] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-5422) htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gareth Carter updated OFBIZ-5422:
---------------------------------

    Attachment: htmlFormMacroLibrary.patch

Change to correctly calculate the number of pages using ceiling rather than floor

> htmlFormMacroLibrary.ftl renderNextPrev does not calculate number of pages correctly
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-5422
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5422
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Gareth Carter
>            Priority: Minor
>         Attachments: htmlFormMacroLibrary.patch
>
>
> There are 2 issues with the existing code.
> 1 - floor is applied to viewSize only not the computed value
> 2 - if the listSize divides with viewSize evenly, you'll get one extra
> eg
> 24/2=12 - no of pages = 13
> 24/5=4.8 - no of pages = 5



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)