[jira] [Updated] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gareth Carter updated OFBIZ-6291:
---------------------------------
    Attachment: minilang_compare.patch

minilang_compare.patch fixes Compare.java. I have remove compareBigDecimals method (even though a comment says not). BigDecimal compareTo disregards scale so 2.0 and 2.00 are the same. See java docs

> Update code to check for types rather than throw ClassCastException
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-6291
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6291
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Gareth Carter
>            Priority: Trivial
>         Attachments: LocalizedConverters.patch, minilang_compare.patch
>
>
> framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java
> framework/base/src/org/ofbiz/base/util/ObjectType.java
> framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java
> all throw ClassCastExceptions and are ignored instead of checking types
> This caused issues in debugging when adding a ClassCastException breakpoint

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)