[jira] [Updated] (OFBIZ-6435) Replace HTML entities where ${groovy: is used by simple code

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-6435) Replace HTML entities where ${groovy: is used by simple code

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-6435:
-----------------------------------
    Description:
Change from eg {noformat}&{noformat} to & .

There are cases where you need to be careful (the XML parser does not allow you to change: eg Eclipse and log warn you.) and cases with multi-lines changes so it' must be done "by hand" (ie no global S/R)

A way that could be 1st tried to do it automatically in (eg) Eclipse would be to change globally with a S/R and then check the XML errors in the IDE.

But, while working on OFBIZ-6332, Pierre Smits told me that in some case the XSDs are not complete. I'm not sure about the impact though. Since the XML parser should be the same in the IDE and when parsing code to operate (then reporting warnings/errors in log). Anyway I agree these changes should be carefully done!

The idea is to show OOTB that using HTML entities in groovy code snippets is not necessary and not a good practice (less legible code)


  was:
Change from eg {noformat}&{noformat} to & .

There are cases where you need to be careful (the XML parser does not allow you to change: eg Eclipse and log warn you.) and cases with multi-lines changes so it' must be done "by hand" (ie no global S/R)

A way that could be 1st tried to do it automatically in (eg) Eclipse would be to change globally with a S/R and then check the XML errors in the IDE.

But, while working on OFBIZ-6332, Pierre Smits told me that in some case the XSDs are not complete. I'm not sure about the impact though. Since the XML parser should be the same in the IDE and when parsing code to operate (then reporting warnings/errors in log). Anyway I agree these changes should be carefully done!

The idea is to show OOTB that using



> Replace HTML entities where ${groovy: is used by simple code
> ------------------------------------------------------------
>
>                 Key: OFBIZ-6435
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6435
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Upcoming Branch
>
>
> Change from eg {noformat}&{noformat} to & .
> There are cases where you need to be careful (the XML parser does not allow you to change: eg Eclipse and log warn you.) and cases with multi-lines changes so it' must be done "by hand" (ie no global S/R)
> A way that could be 1st tried to do it automatically in (eg) Eclipse would be to change globally with a S/R and then check the XML errors in the IDE.
> But, while working on OFBIZ-6332, Pierre Smits told me that in some case the XSDs are not complete. I'm not sure about the impact though. Since the XML parser should be the same in the IDE and when parsing code to operate (then reporting warnings/errors in log). Anyway I agree these changes should be carefully done!
> The idea is to show OOTB that using HTML entities in groovy code snippets is not necessary and not a good practice (less legible code)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)