[jira] [Updated] (OFBIZ-7000) You cannot edit an image in content

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-7000) You cannot edit an image in content

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammed Rehan Khan updated OFBIZ-7000:
---------------------------------------
    Attachment: OFBIZ-7000.patch

Hi,
I have explored the issue and found that there is a condition in DataResourceWorker method to render content of 'text' mime type only, for others it returns exception.

// if the target mimeTypeId is not a text type, throw an exception
if (!targetMimeTypeId.startsWith("text/")) {
    throw new GeneralException("The desired mime-type is not a text type, cannot render as text: " + targetMimeTypeId);
}

We can fix this by setting up mimeTypeID as null in request param

I have added the patch with the changes and also test the same for all contents, kindly share your thoughts on this.


> You cannot edit an image in content
> -----------------------------------
>
>                 Key: OFBIZ-7000
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7000
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Jacques Le Roux
>            Assignee: Mohammed Rehan Khan
>            Priority: Minor
>         Attachments: OFBIZ-7000.patch
>
>
> If you get to
> {code}
> content/control/EditLayout?drDataResourceId=NOCONTENTFOUND&contentId=NOCONTENTFOUND
> {code}
> When trying to editing you get an error
> {code}
> 2016-04-11 10:48:42,932 |http-bio-8443-exec-9 |ScreenFactory                 |I| Got 9 screens in 0.004s from: file:/C:/projectASF-Mars/ofbiz/applications/content/widget/layout/LayoutScreens.xml
> 2016-04-11 10:48:43,051 |http-bio-8443-exec-9 |ScriptUtil                    |W| Error running script at location [component://content/webapp/content/WEB-INF/actions/layout/EditSubContent.groovy]: org.ofbiz.b
> ase.util.GeneralException: The desired mime-type is not a text type, cannot render as text: image/png
> org.ofbiz.base.util.GeneralException: The desired mime-type is not a text type, cannot render as text: image/png
>         at org.ofbiz.content.data.DataResourceWorker.renderDataResourceAsText(DataResourceWorker.java:624) ~[ofbiz-content.jar:?]
>         at org.ofbiz.content.data.DataResourceWorker.renderDataResourceAsText(DataResourceWorker.java:603) ~[ofbiz-content.jar:?]
>         at org.ofbiz.content.data.DataResourceWorker$renderDataResourceAsText.call(Unknown Source) ~[?:?]
>         at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) ~[groovy-all-2.4.5.jar:2.4.5]
>         at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) ~[groovy-all-2.4.5.jar:2.4.5]
>         at EditSubContent.run(EditSubContent.groovy:50) ~[?:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)