[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Swapnil M Mane updated OFBIZ-7311:
----------------------------------
    Description:
In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting

// No space
{code}
ul#preferences-menu a:hover {
text-decoration: none;
}
{code}

// Space of 2
{code}
div.autocomplete ul {
  list-style-type:none;
  margin:0;
  padding:0;
}
{code}

// Space of 4
{code}
.control-area a {
    font-size: 1.1em;
    color: #5CA3D7;
}
{code}

For better readability we should format the existing files with space of 4.

Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.

  was:
This is a placeholder task to capture all tasks regarding the formatting of CSS code and renaming of files for the various themes.

In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting

// No space
{code}
ul#preferences-menu a:hover {
text-decoration: none;
}
{code}

// Space of 2
{code}
div.autocomplete ul {
  list-style-type:none;
  margin:0;
  padding:0;
}
{code}

// Space of 4
{code}
.control-area a {
    font-size: 1.1em;
    color: #5CA3D7;
}
{code}

For better readability we should format the existing files with space of 4.

Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.


> Formatting and renaming of the CSS files as per best practices
> --------------------------------------------------------------
>
>                 Key: OFBIZ-7311
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7311
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Swapnil M Mane
>            Assignee: Swapnil M Mane
>            Priority: Minor
>
> In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
>   list-style-type:none;
>   margin:0;
>   padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
>     font-size: 1.1em;
>     color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)