[
https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil M Mane updated OFBIZ-7311:
----------------------------------
Attachment: OFBIZ-7311-renamed-maincss-to-style.patch
To maintain the consistency, renamed the *maincss.css* to *style.css* (also *mainrtl.css* to *stylertl.css*)
This patch is to update the references of files after renaming.
After applying this patch, kindly run the following commands from OFBiz home
svn mv themes/flatgrey/webapp/flatgrey/maincss.css themes/flatgrey/webapp/flatgrey/style.css
svn mv themes/flatgrey/webapp/flatgrey/mainrtl.css themes/flatgrey/webapp/flatgrey/stylertl.css
svn mv themes/rainbowstone/webapp/rainbowstone/maincss.css themes/rainbowstone/webapp/rainbowstone/style.css
svn mv themes/rainbowstone/webapp/rainbowstone/mainrtl.css themes/rainbowstone/webapp/rainbowstone/stylertl.css
> Formatting and renaming of the CSS files as per best practices
> --------------------------------------------------------------
>
> Key: OFBIZ-7311
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7311> Project: OFBiz
> Issue Type: Improvement
> Reporter: Swapnil M Mane
> Assignee: Swapnil M Mane
> Priority: Minor
> Attachments: OFBIZ-7311-bizznesstime.patch, OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch, OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch, OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch, OFBIZ-7311-tomahawk.patch
>
>
> In CSS files, we are having various inconsistency in the formatting of the code for e.g. we have following types of code formatting
> // No space
> {code}
> ul#preferences-menu a:hover {
> text-decoration: none;
> }
> {code}
> // Space of 2
> {code}
> div.autocomplete ul {
> list-style-type:none;
> margin:0;
> padding:0;
> }
> {code}
> // Space of 4
> {code}
> .control-area a {
> font-size: 1.1em;
> color: #5CA3D7;
> }
> {code}
> For better readability we should format the existing files with space of 4.
> Also for some theme, we named CSS files as *maincss.css* and for some, we named it as *style.css*. We can rename these file as per best practices for consistency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
