[jira] [Updated] (OFBIZ-7324) From facility location should be product based in stock move form.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-7324) From facility location should be product based in stock move form.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Montalbano Florian updated OFBIZ-7324:
--------------------------------------
    Attachment: OFBIZ-7324_tryV2.patch

Hi [~deepak.dixit],
sorry for the duplicate work but given that I'm new to OFBiz, I think it's a good experience for me to try to provide some patch while following your work.

I used the work proposed in OFBIZ-7350 to provide the filtering on the auto-completion of the product location based on the product id given.

There are some changes that I'm unsure of :
- The auto-completion calls the service StockMoveServices#findProductInventorylocations , so I modified it to do a "like" operator check on the field 'locationSeqId'. I feel that modifying this service may have not been appropriated. What is the good way ?

- The screen LookupScreens.xml#LookupProductInventoryLocation now support call with an undefined 'parameters.productId', answering with a more user-friendly error message. In this same screen, I used the field 'conditionFields' to filter the auto-completion but I didn't find this way of doing thing in another part of OFBiz, so I'm wondering if it is ok.

Please give me your thought about this patch. I tried to apply it on a clean trunk and it works (for the Move stock problem only (for now)). But it still doesn't work on other form that could benefit from it (LookupQuoteItem).

> From facility location should be product based in stock move form.
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-7324
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7324
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Deepak Dixit
>            Assignee: Deepak Dixit
>         Attachments: OFBIZ-7324_try.patch, OFBIZ-7324_tryV2.patch
>
>
> From facility location should be product based in stock move form.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)