[jira] [Updated] (OFBIZ-7410) BirtWorker Class

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar updated OFBIZ-7410:
--------------------------------
    Description:
- Make class as final.

- Add a private constructor.

- Make the following public static variables as private
{code}
    public final static String BIRT_PARAMETERS = "birtParameters";
    public final static String REPORT_ENGINE = "reportEngine";
    public final static String BIRT_LOCALE = "birtLocale";
    public final static String BIRT_IMAGE_DIRECTORY = "birtImageDirectory";
    public final static String BIRT_CONTENT_TYPE = "birtContentType";
    public final static String BIRT_OUTPUT_FILE_NAME = "birtOutputFileName";
{code}

- Add get methods for above public variables that changed to private. Also replace the use public static variables with get methods.
{code}
getBirtParameters()
getBirtLocale()
getBirtImageDirectory()
getBirtContentType()
getBirtOutputFileName()
{code}


- Make the following private static variable as final.
{code}
    private static HTMLServerImageHandler imageHandler = new HTMLServerImageHandler();
{code}


  was:
- Make class as final.

- Add a private constructor.

- Make the following public static variables as private
{code}
    public final static String BIRT_PARAMETERS = "birtParameters";
    public final static String REPORT_ENGINE = "reportEngine";
    public final static String BIRT_LOCALE = "birtLocale";
    public final static String BIRT_IMAGE_DIRECTORY = "birtImageDirectory";
    public final static String BIRT_CONTENT_TYPE = "birtContentType";
    public final static String BIRT_OUTPUT_FILE_NAME = "birtOutputFileName";
{code}

- Add get methods for above public variables that changed to private.

- Make the following private static variable as final.
{code}
    private static HTMLServerImageHandler imageHandler = new HTMLServerImageHandler();
{code}

> BirtWorker Class
> ----------------
>
>                 Key: OFBIZ-7410
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7410
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: specialpurpose/birt
>    Affects Versions: Trunk
>            Reporter: Arun Patidar
>            Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
>     public final static String BIRT_PARAMETERS = "birtParameters";
>     public final static String REPORT_ENGINE = "reportEngine";
>     public final static String BIRT_LOCALE = "birtLocale";
>     public final static String BIRT_IMAGE_DIRECTORY = "birtImageDirectory";
>     public final static String BIRT_CONTENT_TYPE = "birtContentType";
>     public final static String BIRT_OUTPUT_FILE_NAME = "birtOutputFileName";
> {code}
> - Add get methods for above public variables that changed to private. Also replace the use public static variables with get methods.
> {code}
> getBirtParameters()
> getBirtLocale()
> getBirtImageDirectory()
> getBirtContentType()
> getBirtOutputFileName()
> {code}
> - Make the following private static variable as final.
> {code}
>     private static HTMLServerImageHandler imageHandler = new HTMLServerImageHandler();
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)