[ https://issues.apache.org/jira/browse/OFBIZ-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7426: -------------------------------- Summary: Enforce noninstantiability to SeoConfigUtil class (was: SeoConfigUtil class) > Enforce noninstantiability to SeoConfigUtil class > ------------------------------------------------- > > Key: OFBIZ-7426 > URL: https://issues.apache.org/jira/browse/OFBIZ-7426 > Project: OFBiz > Issue Type: Sub-task > Components: product > Affects Versions: Trunk > Reporter: Rishi Solanki > Assignee: Anurag Chandak > Priority: Minor > Attachments: OFBIZ-7426.patch > > > - Make class as final. > - Add a private constructor. > - Make the following public variables as final > {code} > public static String module = UtilAccounting.class.getName(); > {code} > - Make the following public static variables as private > {code} > public static final String DEFAULT_REGEXP = "^.*/.*$"; > public static final String ELEMENT_REGEXPIFMATCH = "regexpifmatch"; > public static final String ELEMENT_URL_CONFIG = "url-config"; > public static final String ELEMENT_DESCRIPTION = "description"; > public static final String ELEMENT_FORWARD = "forward"; > public static final String ELEMENT_SEO = "seo"; > public static final String ELEMENT_URLPATTERN = "url-pattern"; > public static final String ELEMENT_REPLACEMENT = "replacement"; > public static final String ELEMENT_RESPONSECODE = "responsecode"; > public static final String ELEMENT_JSESSIONID = "jsessionid"; > public static final String ELEMENT_ANONYMOUS = "anonymous"; > public static final String ELEMENT_VALUE = "value"; > public static final String ELEMENT_USER = "user"; > public static final String ELEMENT_EXCEPTIONS = "exceptions"; > public static final String ELEMENT_CHAR_FILTERS = "char-filters"; > public static final String ELEMENT_CHAR_FILTER = "char-filter"; > public static final String ELEMENT_CHARACTER_PATTERN = "character-pattern"; > public static final String ELEMENT_CATEGORY_URL = "category-url"; > public static final String ELEMENT_ALLOWED_CONTEXT_PATHS = "allowed-context-paths"; > public static final String ELEMENT_CATEGORY_NAME = "category-name"; > public static final String ELEMENT_CATEGORY_URL_SUFFIX = "category-url-suffix"; > public static final String SEO_CONFIG_FILENAME = "SeoConfig.xml"; > public static final int DEFAULT_RESPONSECODE = HttpServletResponse.SC_MOVED_PERMANENTLY; > public static final String DEFAULT_ANONYMOUS_VALUE = "disable"; > public static final String DEFAULT_USER_VALUE = "disable"; > public static final String DEFAULT_CATEGORY_URL_VALUE = "enable"; > public static final String DEFAULT_CATEGORY_NAME_VALUE = "disable"; > public static final String ALLOWED_CONTEXT_PATHS_SEPERATOR = ":"; > {code} > - Also add getDefaultResponseCode() method for following variable after making it private and use it in UrlRegexpTransform.java, SeoContextFilter.java and UrlRegexpContextFilter.java > {code} > public static final int DEFAULT_RESPONSECODE = HttpServletResponse.SC_MOVED_PERMANENTLY; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) |
Free forum by Nabble | Edit this page |