[
https://issues.apache.org/jira/browse/OFBIZ-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohit Koushal updated OFBIZ-7591:
---------------------------------
Attachment: OFBIZ-7591.patch
Thanks [~rishisolankii] for the details. Here is the patch for the issue.
> Enforce noninstantiability to UtilJavaParse class
> -------------------------------------------------
>
> Key: OFBIZ-7591
> URL:
https://issues.apache.org/jira/browse/OFBIZ-7591> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Rishi Solanki
> Assignee: Rohit Koushal
> Priority: Minor
> Attachments: OFBIZ-7591.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private and move them to top of class. Also move the static block initializing it.
> {code}
> // FIXME: Not thread safe
> public static Set<String> serviceMethodNames = new HashSet<String>();
> static {
> serviceMethodNames.add("runSync");
> serviceMethodNames.add("runSyncIgnore");
> serviceMethodNames.add("runAsync");
> serviceMethodNames.add("runAsyncWait");
> serviceMethodNames.add("registerCallback");
> serviceMethodNames.add("schedule"); // NOTE: the service name may be the 1st, 2nd or 3rd param for variations on this
> serviceMethodNames.add("addRollbackService");
> serviceMethodNames.add("addCommitService");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
