[jira] [Updated] (OFBIZ-7715) Enforce noninstantiability to SqlJdbcUtil class

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohit Koushal updated OFBIZ-7715:
---------------------------------
    Attachment: OFBIZ-7715.patch

Thanks [~rishisolankii] for the details. Here is the patch for the issue.

> Enforce noninstantiability to SqlJdbcUtil class
> -----------------------------------------------
>
>                 Key: OFBIZ-7715
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7715
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Rohit Koushal
>            Priority: Minor
>         Attachments: OFBIZ-7715.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
>     public static final int CHAR_BUFFER_SIZE = 4096;
> {code}
> - Make the following protected variable as private and move it and static block to top of class.
> {code}
>     protected static Map<String, Integer> fieldTypeMap = new HashMap<String, Integer>();
>     static {
>         fieldTypeMap.put("java.lang.String", 1);
>         fieldTypeMap.put("String", 1);
>         fieldTypeMap.put("java.sql.Timestamp", 2);
>         fieldTypeMap.put("Timestamp", 2);
>         fieldTypeMap.put("java.sql.Time", 3);
>         fieldTypeMap.put("Time", 3);
>         fieldTypeMap.put("java.sql.Date", 4);
>         fieldTypeMap.put("Date", 4);
>         fieldTypeMap.put("java.lang.Integer", 5);
>         fieldTypeMap.put("Integer", 5);
>         fieldTypeMap.put("java.lang.Long", 6);
>         fieldTypeMap.put("Long", 6);
>         fieldTypeMap.put("java.lang.Float", 7);
>         fieldTypeMap.put("Float", 7);
>         fieldTypeMap.put("java.lang.Double", 8);
>         fieldTypeMap.put("Double", 8);
>         fieldTypeMap.put("java.math.BigDecimal", 9);
>         fieldTypeMap.put("BigDecimal", 9);
>         fieldTypeMap.put("java.lang.Boolean", 10);
>         fieldTypeMap.put("Boolean", 10);
>         fieldTypeMap.put("java.lang.Object", 11);
>         fieldTypeMap.put("Object", 11);
>         fieldTypeMap.put("java.sql.Blob", 12);
>         fieldTypeMap.put("Blob", 12);
>         fieldTypeMap.put("byte[]", 12);
>         fieldTypeMap.put("java.nio.ByteBuffer", 12);
>         fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
>         fieldTypeMap.put("java.sql.Clob", 13);
>         fieldTypeMap.put("Clob", 13);
>         fieldTypeMap.put("java.util.Date", 14);
>         // all of these treated as Collection
>         fieldTypeMap.put("java.util.ArrayList", 15);
>         fieldTypeMap.put("java.util.HashSet", 15);
>         fieldTypeMap.put("java.util.LinkedHashSet", 15);
>         fieldTypeMap.put("java.util.LinkedList", 15);
>     }
> {code}

--
This message was sent by Atlassian JIRA
(v6.3.4#6332)