[jira] [Updated] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-7758) jquery.jgrowl.min.css is linked twice in html page

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohit Koushal updated OFBIZ-7758:
---------------------------------
    Attachment: OFBIZ-7758.patch

Hi [~jacques.le.roux] and [~jamesyong],

Found out the problematic area, In AbstractModelAction.java below  code snippet causing the duplicacy in the JavaScripts and StyleSheets List.
{code}
            // this is a hack for backward compatibility with the JPublish page object
            Map<String, Object> page = UtilGenerics.checkMap(context.get("page"));
            if (page != null) {
                this.field.put(page, newValue);
            }
{code}

The duplicacy can be because of context, globalContext and page contain the reference of single object(i.e layoutSettings).

I Don't know the consequences of removing the above code. So for now providing the alternate solution in the attached patch.

Please let me know if we are good to remove the above code snippet.

> jquery.jgrowl.min.css is linked twice in html page
> --------------------------------------------------
>
>                 Key: OFBIZ-7758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7758
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Trunk
>            Reporter: james yong
>            Priority: Minor
>         Attachments: OFBIZ-7758.patch
>
>
> I am running on trunk rev 1751489 on tomahawk theme.
> In the browser, right-click and view the page source. There is duplicate linking of jquery.jgrowl.min.css i.e.
> {code}
> <link rel="stylesheet" href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css" type="text/css"/>
> <link rel="stylesheet" href="/images/jquery/plugins/jquery-jgrowl/1.4.1/jquery.jgrowl.min.css" type="text/css"/>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)