[jira] [Updated] (OFBIZ-8447) OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-8447) OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devanshu Vyas updated OFBIZ-8447:
---------------------------------
    Attachment: OFBIZ-8447.patch

Uploaded a single patch with all components changes for trunk.

> OFBIZ-7520: Consistency and Readability improvements for if-compare-field tag
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-8447
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8447
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Upcoming Branch
>            Reporter: Devanshu Vyas
>            Priority: Minor
>         Attachments: OFBIZ-8447.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout the application. The correct pattern to write is
> <if-compare-field field="finAccountTrans.statusId" operator="not-equals" to-field="parameters.statusId">
> I found various other ways in which this tag is written, like
> <if-compare-field to-field="partyAcctgPreference.baseCurrencyUomId" operator="equals" field="orderHeader.currencyUom" />
> <if-compare-field operator="equals" field="invoiceTotal" to-field="payment.actualCurrencyAmount">



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)