[jira] [Updated] (OFBIZ-904) Error when "Inventory Facility Id" is left blank in product store settings

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-904) Error when "Inventory Facility Id" is left blank in product store settings

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun Patidar updated OFBIZ-904:
-------------------------------
    Attachment: ofbiz-904.patch

Attached is the patch to fix this issue. Patch included below fixes:

- In process of create/update productStore, I made inventoryFacilityId filed value mandatory if oneInventoryFacility is set to "Y"
- Also fetched facilityId from ProductStoreFacility entity if there is empty ProductStore.inventoryFacilityId.

> Error when "Inventory Facility Id" is left blank in product store settings
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product, specialpurpose/ecommerce
>         Environment: OFBiz Rev. 529997 on Windows XP.
>            Reporter: Michel Dielissen
>         Attachments: ofbiz-904.patch
>
>
> When creating a new store and the "Inventory Facility Id" field is left blank (with the store settings) then the productlist (Browse categories in the e-commerce store) gives an error and is not rendered.
> Error:
> 2007-04-19 10:13:16,515 (http-0.0.0.0-8080-Processor3) [        ModelScreen.java:148:ERROR] Error rendering screen [component://ecommerce/widget/CatalogScreens.xml#productsummary]: org.ofbiz.base.util.GeneralException: Error running BSH script at location [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh]: org.ofbiz.base.util.GeneralException: Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh], line [65]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm. : at Line: 65 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh : if ( product != null ) {
>  (Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm.) (Error running BSH script at [component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh], line [65]: Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm. : at Line: 65 : in file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh : if ( product != null ) {
>  (Sourced file: component://order/webapp/ordermgr/WEB-INF/actions/entry/catalog/productsummary.bsh internal Error: Null value in getAssignableForm.)). Rolling back transaction.
> Think it has something todo with:
> file:/D:/ofbiz/applications/product/script/org/ofbiz/product/inventory/InventoryServices.xml
> 2007-04-19 10:12:27,843 (http-0.0.0.0-8080-Processor3) [  ServiceDispatcher.java:459:DEBUG] Sync service [ecommerce/getInventoryAvailableByFacility]
> So maybe the "Inventory Facility Id" field has to be a required field? Or maybe better to run the "getInventoryAvailableByFacility" only when an Inventory Facility is filled with the store settings?
> Comment Jacopo: this should be improved; for example the facility in the store should be mandatory if the requireInventory flag is set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)