[
https://issues.apache.org/jira/browse/OFBIZ-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kyra Pritzel-Hentley updated OFBIZ-9527:
----------------------------------------
Attachment: OFBIZ-9527_org.apache.ofbiz.accounting.period_and_org.apache.ofbiz.accounting.tax_refactoring.patch
The patch resolves the above mentioned bugs.
In TaxAuthorityServices every possible case sets the variable productCategoryCond, rendering it always not-null. I extracted a method for better readability of the code. The documentation of the new method explicitly states that a non-null value is returned.
> [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax
> ------------------------------------------------------------------------------------
>
> Key: OFBIZ-9527
> URL:
https://issues.apache.org/jira/browse/OFBIZ-9527> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
> Affects Versions: Trunk
> Reporter: Kyra Pritzel-Hentley
> Priority: Minor
> Attachments: OFBIZ-9527_org.apache.ofbiz.accounting.period_and_org.apache.ofbiz.accounting.tax_refactoring.patch
>
>
> PeriodServices.java:42, MS_SHOULD_BE_FINAL
> * MS: org.apache.ofbiz.accounting.period.PeriodServices.module isn't final but should be
> This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
> After adjusting the FindBugs configuration, a new bug has been found in TaxAuthorityServices:
> TaxAuthorityServices.java:350, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> * RCN: Redundant nullcheck of productCategoryCond, which is known to be non-null in org.apache.ofbiz.accounting.tax.TaxAuthorityServices.getTaxAdjustments(Delegator, GenericValue, GenericValue, String, String, Set, BigDecimal, BigDecimal, BigDecimal, BigDecimal, BigDecimal)
> This method contains a redundant check of a known non-null value against the constant null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Locked
