[jira] [Updated] (OFBIZ-9626) [FB] Package org.apache.ofbiz.cmssite.multisite

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Balkir updated OFBIZ-9626:
---------------------------------
    Attachment: OFBIZ-9629_org.apache.ofbiz.cmssite.multisite_bugfixes.patch

class MultiSiteRequestWrapper:
- didn’t do anything, the method’s name, which caused this FB-error, has to be used since the method is overriding another method

class WebSiteFilter:
- Line 69: casting errors won’t occur since ofbiz-api always uses correct parameter types
- Line 83: removed the unnecessary nullcheck; the parameter {{webSite}} can only be null at this point since it was declared null two lines above
- Lines 161, 162, 163: ofbiz-api won’t cause this to be a problem, didn’t fix it

> [FB] Package org.apache.ofbiz.cmssite.multisite
> -----------------------------------------------
>
>                 Key: OFBIZ-9626
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9626
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: cmssite
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>         Attachments: OFBIZ-9629_org.apache.ofbiz.cmssite.multisite_bugfixes.patch
>
>
> - MultiSiteRequestWrapper.java:140, NM_CONFUSING
> Nm: Confusing to have methods org.apache.ofbiz.cmssite.multisite.MultiSiteRequestWrapper.getRequestURI() and org.apache.ofbiz.webtools.artifactinfo.ControllerRequestArtifactInfo.getRequestUri()
> The referenced methods have names that differ only by capitalization.
> - WebSiteFilter.java:68, BC_UNCONFIRMED_CAST
> BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse, FilterChain)
> This cast is unchecked, and not all instances of the type casted from can be cast to the type it is being cast to. Check that your program logic ensures that this cast will not fail.
> - WebSiteFilter.java:69, BC_UNCONFIRMED_CAST
> BC: Unchecked/unconfirmed cast from javax.servlet.ServletResponse to javax.servlet.http.HttpServletResponse in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse, FilterChain)
> This cast is unchecked, and not all instances of the type casted from can be cast to the type it is being cast to. Check that your program logic ensures that this cast will not fail.
> - WebSiteFilter.java:83, NP_LOAD_OF_KNOWN_NULL_VALUE
> NP: Load of known null value in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse, FilterChain)
> The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).
> - WebSiteFilter.java:83, RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE
> RCN: Redundant nullcheck of webSite which is known to be null in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.doFilter(ServletRequest, ServletResponse, FilterChain)
> This method contains a redundant check of a known null value against the constant null.
> - WebSiteFilter.java:161, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.entity.Delegator into HttpSession in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest, HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this session is passivated or migrated, an error will result.
> - WebSiteFilter.java:162, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.service.LocalDispatcher into HttpSession in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest, HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this session is passivated or migrated, an error will result.
> - WebSiteFilter.java:163, J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION
> J2EE: Store of non serializable org.apache.ofbiz.security.Security into HttpSession in org.apache.ofbiz.cmssite.multisite.WebSiteFilter.setWebContextObjects(HttpServletRequest, HttpServletResponse, Delegator, LocalDispatcher)
> This code seems to be storing a non-serializable object into an HttpSession. If this session is passivated or migrated, an error will result.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)