[jira] [Updated] (OFBIZ-9686) [FB] Package org.apache.ofbiz.widget.renderer.html

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Leichert updated OFBIZ-9686:
-----------------------------------
    Attachment: OFBIZ-9686_org.apache.ofbiz.widget.renderer.html_bugfixes.patch

- Line 82,111: Removed useless Control flow line

- Line 470: Removed redundant Null check, and following branches that would never be executed.

> [FB] Package org.apache.ofbiz.widget.renderer.html
> --------------------------------------------------
>
>                 Key: OFBIZ-9686
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9686
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS
>            Reporter: Julian Leichert
>            Priority: Minor
>         Attachments: OFBIZ-9686_org.apache.ofbiz.widget.renderer.html_bugfixes.patch
>
>
> HtmlMenuRenderer.java:82, UCF_USELESS_CONTROL_FLOW
> - UCF: Useless control flow in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.appendOfbizUrl(Appendable, String)
> This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }
> HtmlMenuRenderer.java:111, UCF_USELESS_CONTROL_FLOW
> - UCF: Useless control flow in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.appendContentUrl(Appendable, String)
> This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. For example, this is caused by having an empty statement block for an if statement:
>     if (argv.length == 0) {
>     // TODO: handle this case
>     }
> HtmlMenuRenderer.java:470, NP_LOAD_OF_KNOWN_NULL_VALUE
> - NP: Load of known null value in org.apache.ofbiz.widget.renderer.html.HtmlMenuRenderer.renderLink(Appendable, Map, ModelMenuItem$MenuLink)
> The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)