[jira] [Updated] (OFBIZ-9712) [FB] Package org.apache.ofbiz.entity.finder

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Balkir updated OFBIZ-9712:
---------------------------------
    Attachment: OFBIZ-9712_org.apache.ofbiz.entity.finder_bugfixes.patch

- Diamond Operators fixed

class ByAndFinder:
- Line 37: it’s not necessary for the class to implement serialVerisonUID

class ByConditionFinder:
- Line 39: it’s not necessary for the class to implement serialVerisonUID

class EntityFinderUtil:
- removed unnecessary else
- Line 166: it’s not necessary for the class to implement serialVerisonUID
- Line 212: changed the String {{„|“}} to {{‚|‘}} because it is more efficient
- Line 214: changed the String {{„,“}} to {{‚,‘}} because it is more efficient
- Line 262: it’s not necessary for the class to implement serialVerisonUID
- Line 314: it’s not necessary for the class to implement serialVerisonUID
- Line 337: it’s not necessary for the class to implement serialVerisonUID
- Line 399: it’s not necessary for the class to implement serialVerisonUID
- Line 459: it’s not necessary for the class to implement serialVerisonUID
- Line 473: it’s not necessary for the class to implement serialVerisonUID

class PrimaryKeyFinder:
- Line 47: it’s not necessary for the class to implement serialVerisonUID

> [FB] Package org.apache.ofbiz.entity.finder
> -------------------------------------------
>
>                 Key: OFBIZ-9712
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9712
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Priority: Minor
>         Attachments: OFBIZ-9712_org.apache.ofbiz.entity.finder_bugfixes.patch
>
>
> - ByAndFinder.java:37, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.ByAndFinder is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - ByConditionFinder.java:39, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.ByConditionFinder is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:166, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$ConditionExpr is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:265, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$ConditionList is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:317, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$ConditionObject is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:340, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$LimitRange is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:402, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$LimitView is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:462, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$UseIterator is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - EntityFinderUtil.java:476, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.EntityFinderUtil$GetAll is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.
> - PrimaryKeyFinder.java:47, SE_NO_SERIALVERSIONID
> SnVI: org.apache.ofbiz.entity.finder.PrimaryKeyFinder is Serializable; consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a serialVersionUID field.  A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID.

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)